Repository navigation
Conversation
Every replica's scheduler finds the same expiring credential due and each sends its own refresh, which wastes provider calls and, for a grant that rotates, risks losing the credential. When the store shares a refresh queue the scheduler now asks it instead, and the replica that wins the request refreshes through the same journal-guarded path as before. A grant that rotates waits when the queue is unreachable, since the queue is what keeps two replicas from spending it together; a reusable grant refreshes inline. Stores without a queue behave as before. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the store has a refresh queue, a replica that finds a credential due should publish a request, not refresh inline. Otherwise every replica refreshes the same credential and a single-use grant is burned by whichever loses.