Skip to content

test(codex): prove replicas refresh a credential once on NATS - #23

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-journalwirefrom
yordis/feat-natsstore-journale2e
Open

yordis wants to merge 1 commit into
yordis/feat-natsstore-journalwirefrom
yordis/feat-natsstore-journale2e

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •

Copy link
Copy Markdown
Member
  • The journal only matters if two replicas really cannot both spend a grant. Run two stores against one server: the second adopts the first's receipt without a request, and a crash between claim and receipt leaves an unknown outcome that no replica replays.

The journal only matters if two replicas really cannot both spend a
grant. Run two stores against one server: the second adopts the first's
receipt without a request, and a crash between claim and receipt leaves
an unknown outcome that no replica replays.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis added this pull request to stack #9 November 8, 2026 02:37
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 056c8f6d-57ca-4218-ab6d-ae00794c4006
Commits

Reviewing files that changed from the base of the PR and between 2388b72 and 150d940.

Files selected for processing: 2

  • internal/auth/codex/export_test.go
  • internal/auth/codex/refresh_journal_nats_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant