Skip to content

feat(natsstore): refuse a refresh journal bucket that can lose claims - #21

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-journalfrom
yordis/feat-natsstore-journalprobe
Open

yordis wants to merge 1 commit into
yordis/feat-natsstore-journalfrom
yordis/feat-natsstore-journalprobe

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •

Copy link
Copy Markdown
Member
  • A claim is only as durable as the bucket that holds it. A TTL, a size limit, memory storage or a purgeable stream would let a consumed grant be forgotten and sent twice, so bootstrap hardens a bucket it creates and refuses to start on one that is misconfigured.

A claim is only as durable as the bucket that holds it. A TTL, a size
limit, memory storage or a purgeable stream would let a consumed grant
be forgotten and sent twice, so bootstrap hardens a bucket it creates
and refuses to start on one that is misconfigured.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e53fab29-7ea0-4770-87c4-5bd9f415e08b
Commits

Reviewing files that changed from the base of the PR and between 53fc419 and 5899a70.

Files selected for processing: 3

  • internal/store/natsstore/bootstrap.go
  • internal/store/natsstore/refresh_bucket.go
  • internal/store/natsstore/refresh_bucket_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis added this pull request to stack #9 November 8, 2026 02:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant