[yordis]

• With live sync a management edit can race an edit made on another replica. The config used to be stored later by the file watcher, so the caller got a 200 for a change that was then rejected or overwritten. Commit the config synchronously for shared stores, report the lost compare-and-swap as a conflict, and adopt the winning config so the retry builds on it. Stores that are not shared are unaffected.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 76274a9a-fea5-4d92-91b9-c0bb6de9a6ba

Commits

Reviewing files that changed from the base of the PR and between f922873 and 550a1ad.

Files selected for processing: 9

• internal/api/handlers/management/auth_files_crud.go
• internal/api/handlers/management/config_basic.go
• internal/api/handlers/management/config_conflict_test.go
• internal/api/handlers/management/config_v8.go
• internal/api/handlers/management/handler.go
• internal/store/natsstore/kv.go
• internal/store/natsstore/store.go
• internal/store/natsstore/store_test.go
• sdk/cliproxy/auth/store.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn