Skip to content

feat(natsstore): apply other replicas' config changes to the spool - #17

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-authwatchfrom
yordis/feat-natsstore-configwatch
Open

feat(natsstore): apply other replicas' config changes to the spool#17
yordis wants to merge 1 commit into
yordis/feat-natsstore-authwatchfrom
yordis/feat-natsstore-configwatch

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • A config edit on one replica now reaches the others without a restart: the watched change lands in the spool file, and the file watcher reloads it through the path every config edit already takes. The revision the next edit is checked against advances with each watched change, so an edit made after receiving one is not a false conflict, while a replica that missed one still loses its stale write. A delete of the config is never mirrored, since an empty config would wipe what every replica shares.

@yordis
feat(natsstore): apply other replicas' config changes to the spool
f922873 
A config edit on one replica now reaches the others without a restart:
the watched change lands in the spool file, and the file watcher
reloads it through the path every config edit already takes. The
revision the next edit is checked against advances with each watched
change, so an edit made after receiving one is not a false conflict,
while a replica that missed one still loses its stale write. A delete
of the config is never mirrored, since an empty config would wipe what
every replica shares.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c817a754-fed0-4bc6-bb73-d7d8b7e93cc6
Commits

Reviewing files that changed from the base of the PR and between 6511368 and f922873.

Files selected for processing: 4

  • internal/store/natsstore/configstore.go
  • internal/store/natsstore/configsync.go
  • internal/store/natsstore/configsync_test.go
  • internal/store/natsstore/store.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis added this pull request to stack #9 November 8, 2026 02:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yordis