Skip to content

feat(natsstore): apply other replicas' credential changes to the spool - #16

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-envelopefrom
yordis/feat-natsstore-authwatch
Open

yordis wants to merge 1 commit into
yordis/feat-natsstore-envelopefrom
yordis/feat-natsstore-authwatch

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •

Copy link
Copy Markdown
Member
  • Replicas only saw each other's credentials after a restart. Following the auth bucket and writing its changes into the spool lets the file watcher and synthesizer pick them up unchanged. A change at or below the highest revision already seen is dropped, which orders replays and discards the bucket echoing this replica's own writes without overwriting a newer local edit. An applied file equal to the spool makes no write, and removing a file only deletes the revision this replica saw, so applying a change never feeds back into the bucket.

Replicas only saw each other's credentials after a restart. Following
the auth bucket and writing its changes into the spool lets the file
watcher and synthesizer pick them up unchanged. A change at or below
the highest revision already seen is dropped, which orders replays and
discards the bucket echoing this replica's own writes without
overwriting a newer local edit. An applied file equal to the spool
makes no write, and removing a file only deletes the revision this
replica saw, so applying a change never feeds back into the bucket.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e082d5dc-3a77-411a-8714-5af19c5f4d15
Commits

Reviewing files that changed from the base of the PR and between 01341f9 and 6511368.

Files selected for processing: 7

  • cmd/server/backend.go
  • internal/store/natsstore/authstore.go
  • internal/store/natsstore/authsync.go
  • internal/store/natsstore/authsync_test.go
  • internal/store/natsstore/kv.go
  • internal/store/natsstore/store.go
  • internal/store/natsstore/watch.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis added this pull request to stack #9 November 8, 2026 02:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant