Skip to content

feat(natsstore): store credentials in the auth bucket - #11

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-kvkeysfrom
yordis/feat-natsstore-authstore
Open

feat(natsstore): store credentials in the auth bucket#11
yordis wants to merge 1 commit into
yordis/feat-natsstore-kvkeysfrom
yordis/feat-natsstore-authstore

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Replicas must share credentials without a database, and a stale replica must not overwrite a newer token or a user edit made elsewhere. Saving against the last seen revision and merging the remote value on conflict keeps both, while a credential removed elsewhere stays removed.

@yordis
feat(natsstore): store credentials in the auth bucket
613b72d 
Replicas must share credentials without a database, and a stale replica must
not overwrite a newer token or a user edit made elsewhere. Saving against the
last seen revision and merging the remote value on conflict keeps both,
while a credential removed elsewhere stays removed.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e22e7b4d-6978-4de6-8c1c-aefd03436813
Commits

Reviewing files that changed from the base of the PR and between 7111947 and 613b72d.

Files selected for processing: 4

  • internal/store/natsstore/authstore.go
  • internal/store/natsstore/authstore_test.go
  • sdk/cliproxy/auth/classification.go
  • sdk/cliproxy/service_auth.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis added this pull request to stack #9 November 8, 2026 01:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yordis