Skip to content

feat(natsstore): encode keys and wrap buckets with revision CAS - #10

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-bootstrapfrom
yordis/feat-natsstore-kvkeys
Open

feat(natsstore): encode keys and wrap buckets with revision CAS#10
yordis wants to merge 1 commit into
yordis/feat-natsstore-bootstrapfrom
yordis/feat-natsstore-kvkeys

Conversation

@yordis

@yordis yordis commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Credential ids are file paths while KV keys are subject tokens, so ids need a reversible, collision free mapping. Funneling every write through a revision check makes lost updates between replicas an explicit conflict instead of silent overwrites.

@yordis
feat(natsstore): encode keys and wrap buckets with revision CAS
7111947 
Credential ids are file paths while KV keys are subject tokens, so ids need
a reversible, collision free mapping. Funneling every write through a
revision check makes lost updates between replicas an explicit conflict
instead of silent overwrites.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: daf62ee7-e84c-4807-a71b-014d9f2e8ac9
Commits

Reviewing files that changed from the base of the PR and between d99789d and 7111947.

Files selected for processing: 4

  • internal/store/natsstore/keys.go
  • internal/store/natsstore/keys_test.go
  • internal/store/natsstore/kv.go
  • internal/store/natsstore/kv_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis added this pull request to stack #9 November 8, 2026 01:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yordis