refactor: drop the bundler backend contract - #14
Merged
Conversation
Coverage Report for CI Build 31256271347Coverage decreased (-0.6%) to 90.798%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the bundler backend contract entirely - image variants are always generated with the sharp generator, proxy adapters build urls at runtime instead (see #13).
generateSrcSetModulecreatesSrcSetGeneratordirectly;srcsetBackend,SrcSetBackend,SrcSetBackendFactoryand thebackendoption are removedSrcSetBackendImagefolded intoSrcSetModuleEntrywithurlnarrowed toSrcSetImagePaths: plain string urls existed only for url backends, so the dead branch oftoUrlExpressionis dropped tooEmitImageandSrcSetImagePathsstay - the emit machinery of the integrations themselvesSrcSetModuleEntryre-exports from the integrations found and removed🤖 Generated with Claude Code