Fix pedalboard refetch / last.json restore race condition - #237
Merged
Conversation
rreichenbach
approved these changes
Aug 14, 2026
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. With OTA now, restoring from USB should be less common.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
last.jsonet al are part of the restore dump, there is a race condition where if the mtime is re-scanning during restore, pi-stomp can crash. This PR gates it on a_restoringflag -- this flag only ever transitions fromFalse -> Truebecause the last step of restore is to restart the service.Also fixes a bug where the pedalboards list wasn't correctly being emptied when re-scanning MOD; this meant deleted pedalboards would still show up in the selector.
Bumps to v3.3.1.