Repository navigation
Conversation
Collaborator
|
Great solution, thanks @emerardd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix silent loss of sampling penalties when
TransformerBridge.generate()delegates a stateful/SSM model tohf_generate()withuse_past_kv_cache=False.The fallback builds an allowlist of HF arguments but omits
repetition_penalty. This makes an explicit penalty silently revert to the HF generation default. Forward it unchanged, including the neutral value, so the public Bridge argument determines the requested behavior.HF does not expose a directly equivalent argument for Bridge's additive, token-count-based
freq_penalty. Reject nonzero values on this fallback with an actionableNotImplementedErrordirecting callers to the hooked stateful cache path, rather than silently ignoring the request. Thegenerate()docstring now documents this limitation. Zero frequency penalty and the normal hooked generation loop are unchanged.This is deliberately limited to sampling penalties. It does not resolve other fallback return-format or Bridge-only output options, redesign caching, or modify adapters. No new dependency is required.
Type of change
Validation
test_generate_fallback_flags.py,test_hf_generate_batch_padding.py, andutilities/test_logits_utils.py.repetition_penalty=2.0and differs from the unpenalized sequence.git diff --checkpassed. Full-repository mypy passed for 391 source files.Checklist