DDIR: test shared-input joins through the server - #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDIR: test shared-input joins through the server
Regression coverage only: no server code changes or new query capability.
Factor the existing integration test's process startup into a helper accepting
a worker count. The new scenario installs an arranged edge export and two
consumers that each join request rows
(request_id, node)against it. Feedrequests and graph changes through TCP, then check
peekafter eachtick.This checks ordinary DD semantics through the server path: both consumers see
the shared input, retractions update the answers, equal bindings under distinct
IDs remain distinct, missing keys return no rows, and a reused ID gets the
answer for its new binding.
Four separately named tests run the same scenario on Vec and Corgi with one
and four workers, allowing parallel execution and identifying the failing
configuration directly. The README keeps only a short usage paragraph about
request rows and existing
feed/tick/peekbehavior.Validation
From the worktree, using the existing pinned upstream Corgi:
The server suite passes, including the four backend/worker configurations and
the existing integration tests running concurrently. Existing workspace CI
discovers these tests. No new dependencies, data downloads, external database,
or performance thresholds.