Skip to content

RM-254: Refactor permission checks for thread/channel modes #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHall-1 merged 25 commits into from
Nov 2, 2026
Merged

RM-254: Refactor permission checks for thread/channel modes #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f573f88
Refactor permission checks for thread/channel modes
biast12 Apr 11, 2026
baf5436
Switch to common botpermissions package
biast12 Apr 12, 2026
c758476
Bump common
biast12 Apr 12, 2026
7bad15e
Refactor permission checks to botpermissions
biast12 Apr 12, 2026
ec2fda5
Merge branch 'master' into RM-254
biast12 Apr 25, 2026
19dfc4c
Enable local replace for common module
biast12 Apr 25, 2026
955f0d5
Bump common
biast12 Apr 26, 2026
a79abdd
.
biast12 Apr 26, 2026
5ae9fb4
Merge branch 'master' into RM-254
biast12 Jun 21, 2026
de49c23
bump common
biast12 Jun 21, 2026
888fc0c
Merge branch 'master' into RM-254
biast12 Sep 21, 2026
5c91ada
Use bot standard permissions for claimers
biast12 Sep 21, 2026
2057875
Report channel permission fetch errors
biast12 Sep 21, 2026
090ccfd
Fix overflow and transcript permission checks
biast12 Sep 21, 2026
8097f07
Unify panel permission checks
biast12 Sep 21, 2026
d22d0b6
Use unbranded containers for admin responses
biast12 Sep 21, 2026
e14b1e1
Fix permission checks and response chunking
biast12 Sep 22, 2026
6b6bee2
Bump common
biast12 Sep 27, 2026
aa9d75a
Merge branch 'master' into RM-254
biast12 Oct 4, 2026
d47da77
Use channel-aware permission names
biast12 Oct 4, 2026
2158427
Format missing permissions as code
biast12 Oct 4, 2026
95352f6
Merge branch 'master' into RM-254
biast12 Oct 14, 2026
18086b6
Use channel ID to detect permission target
biast12 Oct 14, 2026
0c330ed
Show channel-specific view permissions
biast12 Oct 14, 2026
6b797f3
Merge branch 'master' into RM-254
biast12 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bot/button/handlers/addadmin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"strings"
"time"

"github.com/TicketsBot-cloud/common/botpermissions"
permcache "github.com/TicketsBot-cloud/common/permission"
"github.com/TicketsBot-cloud/gdl/objects/channel"
"github.com/TicketsBot-cloud/gdl/permission"
Expand All @@ -19,7 +20,6 @@ import (
"github.com/TicketsBot-cloud/worker/bot/command/context"
"github.com/TicketsBot-cloud/worker/bot/customisation"
"github.com/TicketsBot-cloud/worker/bot/dbclient"
"github.com/TicketsBot-cloud/worker/bot/logic"
"github.com/TicketsBot-cloud/worker/bot/utils"
"github.com/TicketsBot-cloud/worker/i18n"
)
Expand Down Expand Up @@ -224,7 +224,7 @@ func (h *AddAdminHandler) Execute(ctx *context.ButtonContext) {
overwrites := append(ch.PermissionOverwrites, channel.PermissionOverwrite{
Id: id,
Type: mentionableType.OverwriteType(),
Allow: permission.BuildPermissions(logic.StandardPermissions[:]...),
Allow: permission.BuildPermissions(botpermissions.StandardPermissions...),
Deny: 0,
})

Expand Down
4 changes: 2 additions & 2 deletions bot/button/handlers/addsupport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"strings"
"time"

"github.com/TicketsBot-cloud/common/botpermissions"
permcache "github.com/TicketsBot-cloud/common/permission"
"github.com/TicketsBot-cloud/database"
"github.com/TicketsBot-cloud/gdl/objects/channel"
Expand All @@ -21,7 +22,6 @@ import (
cmdregistry "github.com/TicketsBot-cloud/worker/bot/command/registry"
"github.com/TicketsBot-cloud/worker/bot/customisation"
"github.com/TicketsBot-cloud/worker/bot/dbclient"
"github.com/TicketsBot-cloud/worker/bot/logic"
"github.com/TicketsBot-cloud/worker/bot/utils"
"github.com/TicketsBot-cloud/worker/i18n"
)
Expand Down Expand Up @@ -248,7 +248,7 @@ func updateChannelPermissions(ctx cmdregistry.CommandContext, id uint64, mention
overwrites := append(ch.PermissionOverwrites, channel.PermissionOverwrite{
Id: id,
Type: mentionableType.OverwriteType(),
Allow: permission.BuildPermissions(logic.StandardPermissions[:]...),
Allow: permission.BuildPermissions(botpermissions.StandardPermissions...),
Deny: 0,
})

Expand Down
2 changes: 1 addition & 1 deletion bot/button/handlers/admindebug/server/blacklistreason.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (h *AdminDebugServerBlacklistReasonHandler) Execute(ctx *context.ButtonCont
}

ctx.ReplyWith(command.NewEphemeralMessageResponseWithComponents([]component.Component{
utils.BuildContainerRaw(
utils.BuildAdminContainerRaw(
ctx,
customisation.Red,
"Admin - Debug Server - Blacklist Reason",
Expand Down
2 changes: 1 addition & 1 deletion bot/button/handlers/admindebug/server/entitlements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func (h *AdminDebugServerEntitlementsHandler) Execute(ctx *context.ButtonContext
}

ctx.ReplyWith(command.NewEphemeralMessageResponseWithComponents([]component.Component{
utils.BuildContainerRaw(
utils.BuildAdminContainerRaw(
ctx,
customisation.Green,
"Admin - Debug Server - Entitlements",
Expand Down
2 changes: 1 addition & 1 deletion bot/button/handlers/admindebug/server/modals/panelsettings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func (h *AdminDebugServerPanelSettingsModalHandler) Execute(ctx *context.ModalCo
}

ctx.ReplyWith(command.NewEphemeralMessageResponseWithComponents([]component.Component{
utils.BuildContainerRaw(
utils.BuildAdminContainerRaw(
ctx,
customisation.Orange,
"Admin - Debug Server - Panel Settings",
Expand Down
Loading
Loading