Repository navigation
v3.4.8 - #264
Merged
Merged
v3.4.8#264
Conversation
Prevent undefined-index notices when ARMv commands are unavailable and when ASUS-WRT temperature/value fields are missing. The fix keeps fallback logic safe and null-coalesces optional outputs before formatting or storing them. Also bumps the plugin version to 3.4.8.
Guard ARMv and AsusWRT values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the robustness and reliability of data retrieval and assignment in the
Monitoringplugin, particularly when handling potentially missing or undefined values. It also updates the plugin version to reflect these changes.Robustness improvements for undefined values
ARMvcommand before accessing its elements to prevent errors when the key is missing in both remote and local command execution paths inMonitoring.class.php. [1] [2]?? '') to ensure that ASUS-WRT related variables such asasus_wifi2g_temp_value,asus_wifi5g_temp_value,asus_fw_check_value, andasus_wan0_ip_valuedefault to an empty string if not set, preventing potential undefined variable issues.Version update
3.4.7to3.4.8ininfo.jsonto reflect the new changes.