Repository navigation
Security rules: drop the group checkboxes; inline selects stop clipping text - #330
Merged
Merged
Conversation
…lip text in WebKit The group header rows keep their name and enabled count but lose the bulk on/off checkbox, along with the bulk write path behind it. Inline native selects had 4px vertical padding inside a 24px box, which WebKit uses to clip the 20px line from the bottom. Drop the vertical padding and tuck the chevron to the right edge so it no longer covers the last character. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetRulesEnabledwrapper, group checkbox helpers and their tests, toast strings) is removed with it.NativeSelect: the 24px box had 4px top/bottom padding, so WebKit clipped the bottom of the 20px text line (e.g. the action column on the Security page). Vertical padding is now 0 for the inline size, and the chevron sits at the right edge so it no longer overlaps the last character. Checked in a WKWebView probe for both Chinese and English labels.🤖 Generated with Claude Code