Repository navigation
[Feat] Replay changed-image decision requests with retained evidence - #72
Draft
linear3735 wants to merge 7 commits into
Draft
linear3735 wants to merge 7 commits into
linear3735 wants to merge 7 commits into
Conversation
added 7 commits
October 8, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required human contributor answers
Is a PR needed? Yes. The human contributor explicitly requested upstream submission and confirmed the customer on October 12, 2026. These summarize their recorded instructions; private conversation material is not reproduced.
Observed failure evidence: the pre-fix collector at
f51b82daccepted probabilities[0.2, 0.2]asok. Running the new failure-retention regression against that parser produced1 failed, 46 passed: expectedparse_error, observedok. With the normalization check, the same suite passes all 47 cases; fork PR CI passes all 129 benchmark cases without skips.Why
The benchmark in #52 does not replay changing screenshot sequences. This adds an ordered collector for official JEV's
/v1/decideand native JEV-VL's/v1/systemone, preserving requests and failures for subsequent comparison.Depends on #52. This Draft targets
mainbecause #52's branch exists only in the contributor's fork. The current main-to-head diff therefore includes #52. The incremental change after #52 (5c59dc4) is 4 files, +605/-4, of which 533 changed lines are code/tests/CI. The displayed main-to-head diff is 12 files, +1861/-0, including 1613 code/test/CI lines. Rebase after #52 merges; do not merge this Draft independently of that dependency review.How
Start with
benchmarks/legs/changed_image_replay.py, then its tests andbenchmarks/README.md. The collector reusesDecisionClient, validates the full manifest before sending anything, preserves repeated images and option order, and stores raw responses, hashes, timings and completion counts. Invalid responses are retained and counted as failures while the sequence continues.What
python -m benchmarks.legs.changed_image_replayand document the two flat JEV-VL contracts separately from the typed decision APIs.1e-6rounding error.tests/benchmarksin the existing CI benchmark job with its fail-on-skip check.The incremental change does not modify the Agents runtime, policy selection, or application actions.
--cache-staterecords the caller's declaration; it does not reset server caches.okchecks response validity, not reference agreement, cache correctness, or task success. Image identifiers hash the URI, not decoded pixels. No speedup is claimed by this collector PR.Verification
Head:
f09748b967792d52014abb3b0c3b1acbd0ba069c; dependency: #52 at5c59dc4229c47d2deea31bd3fdb70ce844eaa3d5.Local Ruff format/check,
ty, full pytest andscripts/smoke.shpassed using the existing contributor environment. The local full suite reported 1100 passed, 198 subtests passed, 43 optional/environment skips; benchmarks reported 129 passed, zero skipped. Fresh Kimi and Codex reviews of the normalization/CI follow-up found no blocking defects.Fork PR CI checked out merge commit
515f46bcf407665117ba303e44e038302d51d02b(headf09748bwith dependency5c59dc4). Its tree is identical tof09748b; it does not validate merging with the latest upstreammain. Benchmarks, Linux core 3.11/3.13 and full succeeded. Browser and Windows jobs were skipped by workflow conditions. The full CI job reported 1035 passed, 107 skipped and 199 subtests passed; these environment-dependent skips are separate from the zero-skip benchmark job.The benchmark job pins the public231 reference and runs
tests/benchmarks, followed by the XML skip guard. Replay setup and commands specify the manifest, provenance and fresh output directory.Demo / evidence
Draft blocker: the required application → Agents decision-agent → Omni inference → independently checked application result recording is not yet available. CPU tests use HTTP fixtures; the collector does not itself execute application actions. A same-run demo and trace must be provided, or the documented exception accepted by a maintainer, before marking ready. This PR does not request an exemption based on a historical ticket replay.
The related online JEV-VL implementation is currently in Omni fork #7, built on Omni #117. Historical H800 screenshot replays used an earlier collector and Omni tree; they are not claimed as validation of this head or as an application demo. Fresh GPU inference, full-request latency and application task quality remain unverified for this submission. Existing private run archives are not presented as public evidence links.