Repository navigation
fix(cli): a failed plan --probe must not recommend evolve (#1093) - #1103
Merged
Merged
Conversation
When --probe refuses, the last next: line and the JSON next field are the repair action, not evolve. JSON also sets ready: false while ok stays about the plan itself. A successful or omitted probe is unchanged.
Collaborator
Author
|
Self-review (Birfy) Tip SHA: b7257c9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1093
--probealready exits non-zero when the model/key/subscription is refused, but the lastnext:line (andalgorithms run --json'snext) still recommendedagentdescent evolve. A reader or a host that followsnextthen starts a run that cannot work and leaves a failed entry in the run store — the case#1048was meant to catch.next:with the first failed row's repair action (for example, renew the subscription). Athen: agentdescent plan <spec> --probeline sits just above it so the probe can be re-run after the fix. The output no longer containsnext: agentdescent evolve.--jsonkeepsokabout the plan/spec itself (the plan is still valid). It addsready: falseand setsnextto the same repair action. Hosts should gate onreadyor the exit code, not onokalone.plan/algorithms runwithout--probe, is unchanged: the last line is stillnext: agentdescent evolve …, exit 0, and JSON is the same object as before plusready: truewhen--proberan and passed. Without--probethere is noreadyornextonplan --json.Tests in
tests/test_plan_probe.pycover both verbs, human and JSON forms, the success path, and the no-flag path. The new assertions fail on main914c626and pass at this tip.