Repository navigation
[ci] Prepare required checks for merge groups - #349
Open
wangtiance wants to merge 1 commit into
Open
wangtiance wants to merge 1 commit into
wangtiance wants to merge 1 commit into
Conversation
## summary - Trigger Release checks, CodeQL and DSH checks for main merge groups. - Compare the full queue range and validate its SHA/ancestry before allowing documentation-only or unrelated-plugin skips. - Report DSH results on every event with job-internal path selection. - Retain queue CodeQL SARIF evidence and document the platform's missing external queue alert status and pending enforcement policy. - Keep full Python selection and existing main/nightly checks. ## validation - 152 CI scope, summary, security, profile and layer tests passed. - Shared static checks passed against the exact staged blobs. - npm run check:i18n and 42 local documentation links passed. - Live merge-group acceptance remains for queue activation. Refs: ThinkFlowLab#273
wangtiance
requested review from
hsliuustc0106 and
princepride
as code owners
November 16, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares PR6 of #273: required-check workflows can run against the entire GitHub merge group before repository queue enforcement is enabled.
merge_group: checks_requestedtriggers to Release checks, CodeQL and DSH plugin checks. Checkout continues to use the event's combined SHA.testsresult with a skip explanation. Plugin inputs, renames, empty/unknown ranges and selector changes retain plugin tests.CodeQL platform limitation
GitHub's open codeql-action#1537 records that merge groups do not emit the external Code scanning results / CodeQL PR status. The official action repository workflow also disables uploads for merge groups.
Queue jobs still run real Python and JavaScript/TypeScript CodeQL analysis, retain SARIF artifacts for 14 days, and fail if expected evidence is absent.
CodeQL / checksrequires both analysis jobs to succeed. PR/main uploads retain their existing behavior. This aggregate proves scan execution and evidence, not alert-severity acceptance.Before PR7 enables enforcement, live queue acceptance and a combined-code alert blocking policy remain necessary. Do not require the absent external PR status on merge groups or treat the execution aggregate as a clean security verdict. This PR neither fabricates an alert-success status nor weakens existing repository rules.
Validation
--noconftest -p ci_profilefor these isolated CI suites; application fixtures were not exercised.npm run check:i18n: 3,014 keys, zero problems; 42 local documentation links verified.merge_groupacceptance; concurrent groups, documentation-only groups, failed-check blocking, CodeQL artifacts and actual required-check names must be verified before PR7 enforcement.Refs #273