Skip to content

[ci] Prepare required checks for merge groups - #349

Open
wangtiance wants to merge 1 commit into
ThinkFlowLab:mainfrom
wangtiance:codex/ci-merge-group-checks
Open

wangtiance wants to merge 1 commit into
ThinkFlowLab:mainfrom
wangtiance:codex/ci-merge-group-checks

Conversation

@wangtiance

Copy link
Copy Markdown
Collaborator

Summary

Prepares PR6 of #273: required-check workflows can run against the entire GitHub merge group before repository queue enforcement is enabled.

  • Add main-targeting merge_group: checks_requested triggers to Release checks, CodeQL and DSH plugin checks. Checkout continues to use the event's combined SHA.
  • Run the shared static configuration over the queue base-to-head range. Allow documentation-only heavy-lane skips only after a successful static receipt and a proven nonempty range. Queue selection validates the checked-out SHA and base ancestry, includes preceding PRs, and falls back to full checks on unknowns.
  • Replace DSH event-level path filters with job-internal full-range selection, so unrelated changes return a stable successful tests result with a skip explanation. Plugin inputs, renames, empty/unknown ranges and selector changes retain plugin tests.
  • Retain separate concurrency groups for non-PR runs. Existing full Python selection, main full checks and nightly checks remain unchanged; no ready-subset cutover or repository rule change.

CodeQL platform limitation

GitHub's open codeql-action#1537 records that merge groups do not emit the external Code scanning results / CodeQL PR status. The official action repository workflow also disables uploads for merge groups.

Queue jobs still run real Python and JavaScript/TypeScript CodeQL analysis, retain SARIF artifacts for 14 days, and fail if expected evidence is absent. CodeQL / checks requires both analysis jobs to succeed. PR/main uploads retain their existing behavior. This aggregate proves scan execution and evidence, not alert-severity acceptance.

Before PR7 enables enforcement, live queue acceptance and a combined-code alert blocking policy remain necessary. Do not require the absent external PR status on merge groups or treat the execution aggregate as a clean security verdict. This PR neither fabricates an alert-success status nor weakens existing repository rules.

Validation

  • 152 CI scope/summary/security/profile/layer tests passed, including real Git ranges, preceding code/plugin changes followed by documentation changes, missing/mismatched/diverged SHAs, renames, selector CLI outputs and failure/cancellation aggregation.
  • Local command used --noconftest -p ci_profile for these isolated CI suites; application fixtures were not exercised.
  • Shared pre-commit configuration passed against exact staged blobs and the entire committed PR diff, including actionlint.
  • npm run check:i18n: 3,014 keys, zero problems; 42 local documentation links verified.
  • Fetched upstream and rebased before publishing. Base includes merged [ci] Run CodeQL security analysis on every PR #347.
  • Hosted PR checks are pending. Local real-Git tests do not claim live merge_group acceptance; concurrent groups, documentation-only groups, failed-check blocking, CodeQL artifacts and actual required-check names must be verified before PR7 enforcement.

Refs #273

## summary

- Trigger Release checks, CodeQL and DSH checks for main merge groups.
- Compare the full queue range and validate its SHA/ancestry before
  allowing documentation-only or unrelated-plugin skips.
- Report DSH results on every event with job-internal path selection.
- Retain queue CodeQL SARIF evidence and document the platform's
  missing external queue alert status and pending enforcement policy.
- Keep full Python selection and existing main/nightly checks.

## validation

- 152 CI scope, summary, security, profile and layer tests passed.
- Shared static checks passed against the exact staged blobs.
- npm run check:i18n and 42 local documentation links passed.
- Live merge-group acceptance remains for queue activation.

Refs: ThinkFlowLab#273
@wangtiance wangtiance added ready ready label to trigger CI type:ci Build, test and release automation area:ci Continuous integration and checks area:docs Documentation / 文档 labels Nov 16, 2026
@github-actions
github-actions Bot requested a review from wuzhf9 November 16, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Continuous integration and checks area:docs Documentation / 文档 ready ready label to trigger CI type:ci Build, test and release automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant