Skip to content

fix(ci): repair failing lint/test jobs and switch to Python 3.14 - #97

Merged
TheTrueAI merged 2 commits into
mainfrom
fix/ci-streamlit-apptest-ruff-format
Nov 3, 2026
Merged

TheTrueAI merged 2 commits into
mainfrom
fix/ci-streamlit-apptest-ruff-format

Conversation

@TheTrueAI

Copy link
Copy Markdown
Owner

Summary

main has been failing the CI lint and test jobs since 911ea34 because newer dependency versions changed behavior. Neither failure came from a code change in this repo.

  • test: newer Streamlit resolves relative AppTest.from_file() paths against the calling test file. As a result, tests/test_pages_unsubscribe.py and tests/test_pages_verify.py looked for tests/immermatch/pages/*.py (13 failures). This anchors PAGE_FILE to the repo root, the same way tests/test_app_ui.py already does.
  • lint: ruff 0.17 now formats Python code blocks inside Markdown. This applies that formatting to the model snippets in AGENTS.md (whitespace only).
  • Python 3.14: switches the Python used by CI, the daily digest workflow, .python-version and the devcontainer image from 3.13 to 3.14. The supported floor (requires-python >=3.10, ruff py310) is unchanged.

Test plan

  • make check on Python 3.14.4: 403 passed, ruff and mypy clean
  • CI-equivalent commands locally: ruff check, ruff format --check, mypy immermatch/ daily_task.py, pytest --cov-fail-under=60 (68.6%)
  • pre-commit hooks pass on both commits
  • CI green on this PR

🤖 Generated with Claude Code

TheTrueAI and others added 2 commits November 3, 2026 20:08
- Newer Streamlit resolves relative AppTest.from_file() paths against
  the calling test file, so the verify/unsubscribe page tests looked
  for tests/immermatch/pages/*.py. Anchor PAGE_FILE to the repo root,
  matching tests/test_app_ui.py.
- ruff 0.17 formats Python code blocks inside Markdown; apply it to
  the model snippets in AGENTS.md (whitespace-only).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bump the Python used by CI, the daily digest workflow, .python-version
and the devcontainer image. The supported floor (requires-python >=3.10,
ruff target py310) is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the test-path fixes and Python environment alignment changes.

No open issues 🎉

What changed in this PR

This PR repairs CI failures caused by dependency behavior changes and aligns development and automation environments on Python 3.14, while retaining Python 3.10 as the supported minimum.

Changes:

  • Anchor Streamlit page-test paths to the repository root.
  • Apply whitespace-only formatting to Python snippets in AGENTS.md.
  • Switch CI, daily digest automation, and local development configuration to Python 3.14.
File Description
tests/​test_pages_verify.py Use an absolute path for the verification page test.
tests/​test_pages_unsubscribe.py Use an absolute path for the unsubscribe page test.
AGENTS.md Reformat Python snippets without changing behavior.
.python-version Select Python 3.14 for local development.
.github/​workflows/​daily-digest.yml Run daily digest automation on Python 3.14.
.github/​workflows/​ci.yml Run all Python CI jobs on Python 3.14.
.devcontainer/​devcontainer.json Use the Python 3.14 development container image.

Review effort: Balanced

@TheTrueAI
TheTrueAI merged commit 385e148 into main Nov 3, 2026
5 checks passed
@TheTrueAI
TheTrueAI deleted the fix/ci-streamlit-apptest-ruff-format branch November 3, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants