Skip to content

fix(web): point the About source link at the public GitHub repo - #171

Merged
thedancingdeveloper merged 1 commit into
mainfrom
fix/about-source-link
Oct 11, 2026
Merged

thedancingdeveloper merged 1 commit into
mainfrom
fix/about-source-link

Conversation

@thedancingdeveloper

Copy link
Copy Markdown
Collaborator

The Settings → About "Source" link (and the redesign mockup) pointed at the private Forgejo host repo.indexarr.net. It now points at the public GitHub repo. Release/registry references in CI and the Dockerfile are intentional and left alone.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@thedancingdeveloper thedancingdeveloper left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review: no blockers (head 7879cc0)

This is one commit and two files.

  • settings-view.component.ts: the About "Source" link changes from the estate host repo.indexarr.net/indexarr/rustnzb (the FYI from my batch-4 review) to https://github.com/TheDancingDeveloper-org/rustnzb. It also adds rel="noopener" to the target="_blank" link, so the opened tab can't reach the app through window.opener.
  • mockups/rustnzb-redesign.html: the same text change.

Rebase: not required

  • The branch is 25 commits behind main (base dfed273), but branch protection doesn't require up-to-date branches (strict: false). GitHub reports MERGEABLE / CLEAN, and git merge-tree against current main (71fea38) is clean; main's changes to that file since dfed273 are elsewhere in it.
  • PR CI (all 11 checks green at 7879cc0) ran against the main of 10 October, so I verified the current merge myself. I merged this head onto 71fea38 locally (not pushed) and ran npm ci --ignore-scripts, ng build --configuration production (passes) and ng test (152/152 tests in 20 files).
  • The built bundle contains href="https://github.com/TheDancingDeveloper-org/rustnzb" with target="_blank" and rel="noopener", and no built chunk mentions repo.indexarr.net.

Follow-ups outside this PR (all already on main)

  • Prebuilt demo bundles: demo/chunk-ZTSACVZS.js and website/demo/chunk-ZTSACVZS.js still contain the old https://repo.indexarr.net/indexarr/rustnzb About link. Rebuild the demo after this merges.
  • Estate infrastructure in the repo: website/deploy/setup-vps.sh prints the deploy webhook URL deploy.indexarr.net/hooks/deploy-rustnzb-website, and website/deploy/vps-caddyfile-block.txt describes the VPS's Caddy layout. Dockerfile references the CI image registry repo.indexarr.net. None is a secret, but if the goal is to keep estate internals out of the public repo, these are what's left.

Not merged. This verdict covers only this head SHA.

@thedancingdeveloper

Copy link
Copy Markdown
Collaborator Author

no blockers (head 7879cc0). A three-line About-link change, reviewed by rustnzb-beta-driver.

🤖 Generated with Claude Code

@thedancingdeveloper
thedancingdeveloper merged commit 12b5d09 into main Oct 11, 2026
11 checks passed
@thedancingdeveloper
thedancingdeveloper deleted the fix/about-source-link branch October 11, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant