Repository navigation
fix(web): point the About source link at the public GitHub repo - #171
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thedancingdeveloper
left a comment
Collaborator
Author
There was a problem hiding this comment.
Security review: no blockers (head 7879cc0)
This is one commit and two files.
settings-view.component.ts: the About "Source" link changes from the estate hostrepo.indexarr.net/indexarr/rustnzb(the FYI from my batch-4 review) tohttps://github.com/TheDancingDeveloper-org/rustnzb. It also addsrel="noopener"to thetarget="_blank"link, so the opened tab can't reach the app throughwindow.opener.mockups/rustnzb-redesign.html: the same text change.
Rebase: not required
- The branch is 25 commits behind main (base dfed273), but branch protection doesn't require up-to-date branches (
strict: false). GitHub reportsMERGEABLE/CLEAN, andgit merge-treeagainst current main (71fea38) is clean; main's changes to that file since dfed273 are elsewhere in it. - PR CI (all 11 checks green at 7879cc0) ran against the main of 10 October, so I verified the current merge myself. I merged this head onto 71fea38 locally (not pushed) and ran
npm ci --ignore-scripts,ng build --configuration production(passes) andng test(152/152 tests in 20 files). - The built bundle contains
href="https://github.com/TheDancingDeveloper-org/rustnzb"withtarget="_blank"andrel="noopener", and no built chunk mentionsrepo.indexarr.net.
Follow-ups outside this PR (all already on main)
- Prebuilt demo bundles:
demo/chunk-ZTSACVZS.jsandwebsite/demo/chunk-ZTSACVZS.jsstill contain the oldhttps://repo.indexarr.net/indexarr/rustnzbAbout link. Rebuild the demo after this merges. - Estate infrastructure in the repo:
website/deploy/setup-vps.shprints the deploy webhook URLdeploy.indexarr.net/hooks/deploy-rustnzb-website, andwebsite/deploy/vps-caddyfile-block.txtdescribes the VPS's Caddy layout.Dockerfilereferences the CI image registryrepo.indexarr.net. None is a secret, but if the goal is to keep estate internals out of the public repo, these are what's left.
Not merged. This verdict covers only this head SHA.
Collaborator
Author
|
no blockers (head 7879cc0). A three-line About-link change, reviewed by rustnzb-beta-driver. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Settings → About "Source" link (and the redesign mockup) pointed at the private Forgejo host
repo.indexarr.net. It now points at the public GitHub repo. Release/registry references in CI and the Dockerfile are intentional and left alone.🤖 Generated with Claude Code