fix: reject non-integer bucket counts - #14991
Open
tomatotomata wants to merge 1 commit into
Open
Conversation
Signed-off-by: ahmadalguydi <ahmadalgaidy@hotmail.com>
mindaugl
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add dedicated validation for
bucket_sort'sbucket_countargument. Non-integer values now raise a clearTypeErrorbefore arithmetic or bucket allocation, including on empty inputs; booleans are rejected explicitly despite inheriting fromintin Python. The existing behavior for positive integer counts is unchanged.Issue reference
Closes #14970
Validation
python -m doctest sorts/bucket_sort.pypython -m ruff check sorts/bucket_sort.pygit diff --checkI used coding assistance to prepare this focused fix and reviewed the rendered diff and test output manually. The patch is limited to
sorts/bucket_sort.py.