Conversation
Author
|
Hi, friendly ping on this one. The CI workflows (PHP Composer, Code style) are waiting for maintainer approval since this is my first contribution here. Could someone approve the run and take a look when you have a moment? Happy to adjust anything. Thanks! |
vman-cooks
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated PHPUnit test class for
Utils/ExecutionTime.php, which previously had no test coverage.Verified locally:
phpunit tests— 287 tests, OK (285 before this change)vendor/bin/phpcs -n tests/Utils/ExecutionTimeTest.php— cleanThe tests assert that no output is emitted while the timer is alive and that
__destruct()reports a plausible elapsed time, including that the reported interval covers the sleep duration.DIRECTORY.mdis updated to list the new test file, following the existing pattern.