Skip to content

fix: unbiased Fisher-Yates in bogoSort; do not mutate RGB input #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeeshanzzz788 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: unbiased Fisher-Yates in bogoSort; do not mutate RGB input #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Conversions/RgbHslConversion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const rgbToHsl = (colorRgb) => {
throw new Error('Input is not a valid RGB color.')
}

let colorHsl = colorRgb
// Work on a copy so the caller's RGB array is not mutated
let colorHsl = colorRgb.slice()

let red = Math.round(colorRgb[0])
let green = Math.round(colorRgb[1])
Expand Down
11 changes: 5 additions & 6 deletions Sorts/BogoSort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@ export function isSorted(array) {
}

/**
* Shuffles the given array randomly in place.
* Unbiased Fisher–Yates shuffle of the given array in place.
* Each permutation is equally likely.
*/
function shuffle(array) {
for (let i = array.length - 1; i; i--) {
const m = Math.floor(Math.random() * i)
const n = array[i - 1]
array[i - 1] = array[m]
array[m] = n
for (let i = array.length - 1; i > 0; i--) {
const j = Math.floor(Math.random() * (i + 1))
;[array[i], array[j]] = [array[j], array[i]]
}
}

Expand Down
Loading