Repository navigation
chore(n8n): make the validate script run - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm --filter @teslemetry/n8n-nodes-teslemetry validate(n8n-node lint) failed before it linted anything:Command "eslint" not found. This PR makes it run.@n8n/node-clifrom^0.17.0to^0.51.5. n8n's publishing guide requires 0.23.0 or later. Addeslint@9.29.0, the version that node-cli pins.packages/n8n-nodes-teslemetry/eslint.config.mjs, which uses node-cli'sconfig. It ignorestest/,scripts/and the tool config files, becausefilesis["dist"]and they never ship..pnpmfile.cjs. typescript-eslint needs the TypeScript compiler API, whichtypescript@7no longer ships. The hook gives typescript-eslint the@typescript/typescript6@6.0.2build in place of the workspace's TypeScript 7 peer. n8n's scanner pins the same build. Nothing else in the workspace changes.Only development tooling changes. The published tarball does not change, so this PR has no changeset.
What
validatereports nowvalidateruns, but it fails. It reports 52 errors and 5 warnings insrc/:no-case-declarations,no-explicit-any,missing-paired-item,node-connection-type-literal,no-credential-reuse,require-node-description-fields, icon rules andnode-usable-as-tool. This PR leaves them unfixed on purpose. They are code changes, and they matter only for n8n Cloud verification. That work is deferred:npx @n8n/scan-community-packagealso fails 0.5.1 on the bundled SDK's timers,events,globalThisandconsole, and a later task will decide on verification.Checks
pnpm install --frozen-lockfilepasses with the new lockfile and pnpmfile.pnpm lint(oxlint) passes.pnpm --filter @teslemetry/n8n-nodes-teslemetry buildandtscpass.