test: strengthen MCP directory preflight - #365
Conversation
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8960f4064f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(advertisedInstructions).not.toMatch( | ||
| /\b(?:send|provide|share|upload|attach)\b.{0,40}\b(?:chat|conversation) history\b/i, | ||
| ); |
There was a problem hiding this comment.
If a tool or server description asks callers to “provide conversation context,” both assertions pass because they only recognize chat/conversation history or user memory. This contradicts the new preflight claim that CI rejects conversation-context requests and could allow directory-disallowed context collection to reach submission; extend the guard to cover conversation context and equivalent phrasing.
Useful? React with 👍 / 👎.
2 participants
Summary
Verification
npm run test --workspace @terminal49/mcp -- --run(223 tests)npm run build --workspace @terminal49/mcpnpm run lint --workspace @terminal49/mcpgit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.