fix: address Anthropic MCP directory blockers - #360
Conversation
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Akshay Dodeja <dodeja@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6592c7d7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!hasValidIso6346CheckDigit(number)) { | ||
| throw new ContainerCheckDigitError(number); |
There was a problem hiding this comment.
When a caller explicitly supplies numberType: 'bill_of_lading' or 'booking_number', an identifier that happens to match ^[A-Z]{3}[UJZ]\d{7}$ is still treated as an ISO 6346 container and can be rejected before reaching the API. Carrier-prefixed shipment identifiers can share this shape (for example, MSCU1234567), so a valid non-container request may receive a permanent check-digit error. Apply this validation only when the selected or inferred type is actually container.
Useful? React with 👍 / 👎.
2 participants
Summary
numberin thetrack_containerinput schemaContext
Addresses Anthropic MCP Directory High Priority review blockers tracked in DEV-12451. The separate Medium-priority Mintlify docs work is intentionally excluded.
Verification
npm run test --workspace @terminal49/mcp -- --run(220 tests passed)npm run build --workspace @terminal49/mcpnpm run lint --workspace @terminal49/mcpnpx tsc --noEmit -p tsconfig.jsonNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.