Generalise reserve margin constraints for region/tech groups

[idelder]

Stacked on PR #350

Generalises the reserve margin constraints to allow reserves over groups of regions. Also now uses tech groups instead of the unique reserve set. Finally, makes operating_reserve_margin and planning_reserve_margin separate constraints that can be applied at the same time (rather than switched in config)

This allows:

• multiple superimposed reserve margin constraints on different groups of technologies
• stacking operating reserves with planning reserves
• reserve margin constraints on non-electricity technologies, like oil refineries
• reserve margins summed over multiple regions (e.g. ERCOT as a whole instead of texas east/west individually)

Added a reserve test that checks against a cached LP file for identical model formulation. Any changes are diagnosably printed on test failure.

Added a v4.1 schema for this change and v4->v4.1 migrator with test.

As a result, the rps_requirement constraint (already deprecated) was removed as it depended on the now-absent tech_reserve set. This constraint is structurally identical to the limit_activity_share constraint now anyway and the migrator moves rps_requirement to limit_activity_share by creating a tech group for the past tech_reserve set.

Also did some refactoring and docs rework to try to clarify how all this is supposed to work. These constraints were a magnet for bugs in the past.

New docs for group summation
New docs for mathematical formulation

Used the LP file comparer to confirm that, except for the one bug fixed, this version produces identical constraints.

One bug found:
Exchange techs are allowed to be annual. The previous reserve margin constraint did not sum annual exchange flows for its proxy demand.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7ca0ccfd-4b0c-4ebe-811e-6c8a648f4168

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 73.09059% with 303 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
temoa/utilities/migrate_v4_to_v4_1.py	9.88%	154 Missing and 1 partial ⚠️
tests/utilities/compare_lp.py	70.04%	37 Missing and 25 partials ⚠️
...xtensions/unit_commitment/components/commitment.py	81.45%	14 Missing and 9 partials ⚠️
...moa/extensions/unit_commitment/core/data_puller.py	85.10%	9 Missing and 5 partials ⚠️
temoa/components/reserves.py	89.01%	4 Missing and 6 partials ⚠️
...s/economies_of_scale/components/cost_invest_eos.py	56.52%	6 Missing and 4 partials ⚠️
temoa/components/operations.py	82.35%	4 Missing and 2 partials ⚠️
temoa/components/limits.py	58.33%	5 Missing ⚠️
tests/test_reserve_margins.py	90.47%	3 Missing and 1 partial ⚠️
temoa/components/commodities.py	50.00%	2 Missing and 1 partial ⚠️
... and 6 more

📢 Thoughts on this report? Let us know!