Repository navigation
feat(calendar): give the calendar one address per language - #59
Merged
maxitect merged 7 commits intoNov 13, 2026
Merged
Conversation
✅ Deploy Preview for clarksbowlingclub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
maxitect
marked this pull request as ready for review
November 13, 2026 23:46
maxitect
deleted the
feat/58-calendar-at-calendrier-in-french-and-calendar-in
branch
November 13, 2026 23:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The advent calendar gets one address per language:
/calendrieris always French,/calendaralways English. The language no longer depends on?isFrench, the browser or the site's cookie.Changes
src/app/(calendar)/_page/CalendarPage.tsx) with the locale taken from the path. Same doors, settings, gate (getPublicState) and member preview.<link rel="canonical">andhreflangalternates (fr,en) on both pages once the calendar is open; thenoindexholding page carries neither. The sitemap is untouched, so neither is listed.<html lang>isfrorenfrom the server, holding page included./calendrier?isFrench=falseredirects (307) to/calendar, and/calendar?isFrench=trueto/calendrier. A plain address never redirects by browser language./calendrieron the French site and/calendaron the English one.calendaras forcalendrierinsrc/lib/security/headers.ts. Without a database,/calendaris hidden like/calendrier.Path=/(it was/calendrier), so doors opened on one address show on the other. An old/calendriercookie is merged in when read and removed on the next door opened.Acceptance criteria
/calendrierFrench,/calendarEnglish, whatever the browser language and site cookie?isFrench=falseon/calendrierlands on/calendar,?isFrench=trueon/calendarlands on/calendrierCloses
Closes #58
Notes
EN/FR(named "English" / "Français" for screen readers) so the sound button stays on one line at 390 px./calendar?isFrench=false. The page ignores the parameter and nothing loops. Stripping it needs a proxy on these two paths, which I left out./answersx-nextjs-prerender: 1, with or without the calendar cookie.Review
Verdict: ALL CLEAR
Rounds: 2
/calendarserved<html lang="fr">; the holding page has no script to correct itPath=/calendriercookie hid doors opened on/calendarnoindexholding page?isFrenchstays in the URL after the redirectRe-verified: AC1 (browser) PASS, AC2 (browser) PASS, AC3 (api) PASS, AC4 (browser) PASS, AC5 (api, shifted clock, Visible off on 5 December, member preview) PASS, AC6 (browser) PASS · check.sh PASS
Evidence
Production build on port 4058 against Neon
dev, withDateshifted by a preload (FAKE_NOW); Chromium headless via Playwright.AC1
AC2
AC3
AC4
A test door was inserted on Neon
dev(and deleted afterwards).AC5
HOLDING is the page with
<meta name="robots" content="noindex">and no script; the count ofapi/calendar/audioin the HTML was 0 everywhere.audio/1is 404 throughout because no door ondevhas audio. The "Visible" switch and the preview sharegetPublicStateandisMemberwith both pages, which this change does not touch.AC6
With the test door in place the console showed two 404s for its missing audio file; that is the test row, not the pages.