Repository navigation
feat(calendar): open on 1 December, with a home page button - #57
Merged
maxitect merged 4 commits intoNov 13, 2026
Merged
Conversation
✅ Deploy Preview for clarksbowlingclub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
maxitect
marked this pull request as ready for review
November 13, 2026 23:13
maxitect
deleted the
feat/56-calendar-opens-on-1-december-by-itself-with-a-home
branch
November 13, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The advent calendar now opens to the public at 00:00 Paris time on 1 December by itself, and the home page shows a button to it from 1 to 24 December. "Visible" becomes the off switch.
Changes
/calendrierand its endpoints are public from 1 December of the calendar's year (Paris midnight, ignoring "Opens at hour", which still decides when each door opens). Before that the public gets the holding page; signed-in members keep the preview. ReusesgetCalendarDayfromsrc/lib/calendar/schedule.tsingetPublicState.CalendarButtonlinks to/calendrier, French and English, shown 1 to 24 December Paris time. The date is checked in the browser (useSyncExternalStore, server snapshot is "hidden"), so/stays static. It sits above the footer, clear of the video controls.Acceptance criteria
/stays static/or/calendrierCloses
Closes #56
Notes
20261113_225308_visible_on_by_defaultsets the column default to true and sets any stored row to true. Production has no saved calendar settings yet (no row; the column defaulted to false), so today the rewrite changes nothing there. It is there for a save made before this merges: under the old meaning, a stored "off" only meant "not launched yet", and without the rewrite it would keep the calendar hidden on 1 December. It applies after the production migrations initial, calendar, calendar_checks and carousel (proved on a copy ofmain). No hand-written constraint, so no register entry.defaultYear, not the admin "Year" field, because reading the setting would make/render per request. Changing "Year" for a later December means updating that constant, or a follow-up./calendrier?isFrench=…), because the toggle's choice does not survive the full page load into the calendar's own layout.Review
Verdict: ALL CLEAR
Rounds: 2
defaultYear(2026), not the admin "Year"/is cached; needs a decision before December 2027frame-srcerror for Netlify's preview drawer (app.netlify.com)Re-verified: AC3 home button, now linking to
/calendrier?isFrench=true|false(browser, local production build, fixed clock, EN/FR, 1280/390) PASS · AC1 (api, shifted server clock, plus "Opens at hour" 9 at 00:30 on 1 December: 200, today 0) PASS · AC5 (browser, deploy preview) PASS apart from the preview drawer · AC6 (db,previewreset frommain) PASS · check.sh PASSEvidence
AC1
Production build on port 4056 against Neon
dev(no settings row, so defaults), withDateshifted by a preload (FAKE_NOW).HOLDING is the page carrying
<meta name="robots" content="noindex">and no script./api/calendar/audio/1is 404 throughout because no door has audio on that branch, so it cannot tell open from closed there; it sharesgetPublicStatewith/api/calendar.AC2
AC3
Headless Chromium,
Dateshifted in the page. Button box and whether it overlaps the pause or mute button (it never does):Screenshots were reviewed at 390 px (EN) and 1280 px (FR): the button sits above the footer icons, clear of the controls and the logo.
AC4
On the deploy preview (
https://deploy-preview-57--clarksbowlingclub.netlify.app):AC5
A
securitypolicyviolationlistener was installed on each page and logged nothing.AC6
Neon
previewreset to its parent (a copy ofmain), a "Visible off" row inserted, then: