Repository navigation
fix: keep library landing heroes inside narrow screens - #1481
Conversation
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Responsive hero layout src/components/landing/LibraryLanding.tsx |
When stackHero is true, the hero grid uses one column. The library-name heading uses a smaller base size and adds a size step at widths of at least 400px. |
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix
Suggested reviewers: abeuty, tombeckenham
Merge Risk: 
2884a
-
No actionable merge-blocking risk was identified in this layout change.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names the main change: keeping library landing heroes inside narrow screens. The raw summary confirms the change in LibraryLanding.tsx: a one-column grid when stackHero is true, and a smalle… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: keeping library landing heroes inside narrow screens. The raw summary confirms the change in LibraryLanding.tsx: a one-column grid when stackHero is true, and a smaller heading size below 400px. The objectives state the fix targets the Markdown hero's implicit grid column overflowing at 320px. The title uses the conventional fix: prefix and is specific and concise, so it passes.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 2884a98 | Commit Preview URL Branch Preview URL |
Nov 01 2026, 04:43 PM |
At 320px, the Markdown landing hero's implicit grid column grows to the wordmark's 346px minimum width, clipping the title and the copy beside the viewport edge. Give the single-column hero an explicit zero-minimum grid track and use the existing smaller display token below 400px. The larger typography resumes at 400px.
The change applies to the shared library landing shell. It does not change the breadcrumb overlay from #1480.
Validation:
pnpm testpassed. Reproduced the production failure in WebKit, then checked the actual local component for Markdown, Highlight and Query at 320, 400 and 1280px. At 320px, Markdown’s title fits within the 280px content column and the copy wraps inside the viewport. The 400px and desktop title dimensions stay unchanged. No live-provider or authenticated flows were exercised.Summary by CodeRabbit