fix(routes/index): prevent npm downloads counter from overflowing on mobile - #1107
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesAdoption proof display
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm downloads counter on the landing page runs out of room on small phones. Reported from an iPhone SE (375px), where the number reads as clipped.
Measurements
At 375px the stat block has
327pxof usable width (375 − 24 − 24from the panel'sp-6). The counter renders inui-monospaceattext-4xl/ 36px:15,906,312,010at 36px15,906,312,010at 30px24px of headroom is already tight, and the value only grows — one more digit (crossing a trillion) needs 368px at 36px and overflows outright.
Fix
text-4xl→text-3xl sm:text-4xl, so phones render at 30px and everything fromsmup is unchanged.The
per week/github starspair below was checked too: attext-xlthe widest (133,039,817, 132px) fits its 152px column, so it needs nothing.Verified
Locally below the
smbreakpoint the counter computes to30pxand measures253px; at ≥640px it stays36px/303pxas before.Summary by CodeRabbit