Refactor SDL/FreeRTOS implementation to support macOS simulator properly - #653
KenVanHoeylandt wants to merge 2 commits into
Conversation
This fixes macOS support. Updated GitHub Actions to publish macOS simulator build for testing, updated amd64 to x86_64 for consistent naming.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe simulator action now requires an Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The simulator artifact naming now matches the Linux and macOS workflow inputs and release output directories. No actionable current-head risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 7 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: e6ea5acb-9956-4ab3-a2e0-86daa0775aac
📒 Files selected for processing (11)
.github/actions/build-simulator/action.yml.github/workflows/build-simulator.ymlDevices/simulator/Source/Main.cppDevices/simulator/Source/Simulator.hDevices/simulator/Source/drivers/sdl_bridge.cppDevices/simulator/Source/drivers/sdl_bridge.hDevices/simulator/Source/drivers/sdl_display.cppDevices/simulator/Source/drivers/sdl_input.cppDevices/simulator/Source/drivers/sdl_input.hDevices/simulator/Source/drivers/sdl_keyboard.cppDevices/simulator/Source/drivers/sdl_pointer.cpp
💤 Files with no reviewable changes (2)
- Devices/simulator/Source/drivers/sdl_keyboard.cpp
- Devices/simulator/Source/drivers/sdl_pointer.cpp
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Summary by CodeRabbit
New Features
Bug Fixes