Repository navigation
Add Swift package SystemSoundsLibrary with DocC docs and SoundBrowser example - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers #20, includes #21/#22.
#20 was closed unmerged when its base branch
data/sounds-jsonwas deleted after #18 merged. #21 (DocC) and #22 (SoundBrowser) were merged intofeature/swift-package, not intomaster. This PR cherry-picks the same four commits onto currentmaster. The files are byte-identical tofeature/swift-package.Why it's one PR: the DocC catalog lives inside the package target, and the example app links the package through a local reference. Neither builds on
masterwithout the package. Separate PRs would have to be stacked again, which is what caused the problem.Contents, one commit each:
Package.swift(swift-tools 6.0; iOS 15, tvOS 15, visionOS 1, Mac Catalyst 15, macOS 12)SystemSound(Sendable, 418 constants generated fromdata/sounds.json,@availableon newer IDs,screenUnlockeddeprecated)SystemSoundPlayer, plusFileSound, which frees its sound ID automaticallyswift.yml: runsswift build+swift test, checks the generated catalog withgenerate_swift.py --check, and builds for 4 platformsdocc.yml(from Add DocC documentation for SystemSoundsLibrary #21):docc convert --warnings-as-errors, plus an output check (both commits).Examples/SoundBrowser(from Add SoundBrowser SwiftUI example app #22): SwiftUI iOS 17+, searchable, grouped by folder, tap to play, shows ID and path, share or save the file.example.ymlbuilds it for the iOS Simulator. Refs If possible to export all the sounds? #2, Swift version? #7.The existing Objective-C demo app, its project, target, paths and README content are unchanged. The must-not-break check passes.