Repository navigation
fix(report): refuse mixed datasets unless asked, and keep secrets and paths out of what is shared - #87
Merged
Conversation
… paths out of what is shared #43: plumbline report took the dataset identity from the first artifact and rendered every arm under it, so runs over different datasets printed as if comparable ("against dataset 02496ef4, 1 rows, 6 rows"), and two runs of one adapter got identical "### mock" headings. Different datasets are now refused with the hashes named, unless --allow-mixed is passed; then the header says how many datasets there are and that they are not comparable, and every arm names its dataset and row count. Arms sharing an adapter name are told apart by model, then by run time. #46: - redact walked dicts only, so {"endpoints": [{"api_key": ...}]} reached the artifact. It now walks lists and tuples. - The report and the artifact named the dataset by the path as given, so an absolute path shared a username and directory layout. A dataset inside the working directory is named relative to it, one outside by its file name; the dataset hash still identifies the rows. - A backtick in --model ended its code span early. Values in code spans use a longer fence when they contain one. Fixes #43. Fixes #46. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43. Fixes #46.
#43:
plumbline reportmixed datasets.against dataset 02496ef4, 1 rows, 6 rows), and two runs of one adapter got identical### mockheadings.--allow-mixedis passed. With it, the header says how many datasets there are and that they aren't comparable, and every arm names its dataset and row count.#46: what leaves the machine in a shared file.
redactwalked dicts only, so{"endpoints": [{"api_key": ...}]}reached the artifact. It now walks lists and tuples too.--modelended its code span early. A value in a code span now gets a longer fence when it contains one.Checked
mainand pass now:--allow-mixed, both hashes are named;we`irdrenders as`` we`ird ``;d.jsonlin the report and the artifact;plumbline reportrefuses, then allows with--allow-mixed.ruff,mypy --strict, the fullpytestsuite, and the site build all pass. The example report is unchanged: its dataset path was already relative, and its one arm keeps its heading.🤖 Generated with Claude Code