Repository navigation
Move project URLs back under [project] in pyproject.toml - #303
Conversation
|
I think the relocation is good, and would personally prefer these also be under its own table (ping @ocefpaf): [project.urls]
documentation = "https://teos-10.github.io/GSW-Python/"
homepage = "https://www.teos-10.org/"
repository = "https://github.com/TEOS-10/GSW-python"This would match the style/examples given in the python packaging guide, in addition to being in a more expected location. |
@DocOtak we are using https://github.com/tox-dev/pyproject-fmt, that is a PyPA blessed tool to lint and fix the pyproject.toml. Looks like this is a case where the software is ahead of the docs. I don't have a strong opinion, but we would need to disable that tool for this to pass. |
|
It's a config if we'd want to change: https://pyproject-fmt.readthedocs.io/en/latest/formatting.html#table-formatting |
Sure, I meant the default/desired behavior in the docs. We had the table and the tool chose this one as the preferred/blessed one. |
The
urls.*keys currently sit afterdev = [...], so TOML puts them in[dependency-groups]instead of[project]. That has two effects on main:uv pip install .(oruv sync) fails to parse the file, since dependency groups must be lists:Project-URLentries inPKG-INFO, so the next PyPI release would lose the documentation/homepage/repository links (3.6.23 still has them).This PR moves the three lines back under
[project], right afterdependencies.Checked locally:
Project-URLentries again;uv pip install -e .works, andpytest gsw/testspasses (670 passed) on Python 3.14 with numpy 2.5.4 and pandas 3.1.0;pyproject-fmt2.30.3 (the version pinned in.pre-commit-config.yaml) leaves the file unchanged.