Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

Add Ledger support #75

Open
Open

Description

The Ledger companion wallet for Komodo suffers from the lack of an important Komodo-specific feature that allows KMD holders to claim interest. It does not seem like Ledger will be implementing anything soon. Ledger CTO recently stated on their slack channel regarding a question about this issue: "we don't have the dev bandwidth to do that in the near future". They also don't want to work on it because "the Chrome apps are going to be deprecated".

Fortunately there might be an easy solution to the problem for KMD holders that want store their KMD in a Ledger-based account. Ledger provide a NodeJs API for communicating with the device app. The api works both over u2f (in-browser) and node-hid (native bindings). Since Iguana seems to be a NodeJS application it should be easy to add Ledger support to Iguana and Agama using this API.

Activity

  1. pbca26 commented on Nov 23, 2017

    @pbca26
    Collaborator

    @lenondupe Thanks for suggestion. I'm aware of it.
    I haven't played with Ledger before. How does it send transactions? Do they have an interface for that? Where do those transactions go? I assume to Ledger specific end points/servers?

  2. pbca26 commented on Nov 23, 2017

    @pbca26
    Collaborator

    Are you saying it's possible to send/receive data between js app and ledger firmware?

  3. pbca26 commented on Nov 23, 2017

    @pbca26
    Collaborator

    could you explain where do i get all those hex values? Is it described somewhere in docs or reference materials?

  4. pbca26 commented on Nov 23, 2017

    @pbca26
    Collaborator

    Thanks a lot. I will definitely look into that.

  5. CHMEX commented on Nov 23, 2017

    @CHMEX

    Thank you both! It would be a very nice solution.
    Michael

  6. Zeehenk commented on Nov 25, 2017

    @Zeehenk

    Would be great of this could be solved!

  7. pbca26 commented on Nov 27, 2017

    @pbca26
    Collaborator

    @lenondupe i have a question about creating and signing a tx. createPaymentTransactionNew_async doesn't have any output values in args list, only output script. How can I specify output amount? I assume I need to write something similar to yours signTx_async ?

  8. pbca26 commented on Nov 27, 2017

    @pbca26
    Collaborator

    @lenondupe thanks will try to get an invite there.
    Another question how do I run the code in browser mode? Compile through browserify?

  9. Zeehenk commented on Nov 28, 2017

    @Zeehenk

    FYI: LedgerHQ/ledger-nano-s#21
    Posted by lead dev of KOMODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions