Repository navigation
feat(video): add support for legacy MPEG-2 and H.263+ encoders - #5194
ReenigneArcher wants to merge 5 commits into
Conversation
Bundle ReportChanges will increase total bundle size by 2.07kB (0.09%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
==========================================
+ Coverage 17.85% 18.05% +0.19%
==========================================
Files 111 111
Lines 24605 24793 +188
Branches 10894 10973 +79
==========================================
+ Hits 4393 4476 +83
- Misses 14945 16698 +1753
+ Partials 5267 3619 -1648
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 56 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
4b0586b to
0b8181d
Compare
0b8181d to
aa27a8c
Compare
Bundle ReportChanges will increase total bundle size by 2.05kB (0.21%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
Files in
|
aa27a8c to
1bfd40e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
==========================================
+ Coverage 50.30% 50.54% +0.24%
==========================================
Files 146 149 +3
Lines 31717 32630 +913
Branches 13449 13814 +365
==========================================
+ Hits 15954 16492 +538
- Misses 12963 14472 +1509
+ Partials 2800 1666 -1134
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 56 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fd2848c to
cdb2438
Compare
Screenshot ComparisonPR #5194 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: AppImage-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
cdb2438 to
f84c487
Compare
f84c487 to
0659a74
Compare
|
Description
Add opt-in MPEG-2/H.262 and H.263+ streaming for any client implementing the Sunshine codec extension, including Moonlight-XboxOG #194. Enable them in Advanced settings or with
mpeg2_mode = 2andh263p_mode = 2; both remain unadvertised by default.Sunshine probes and selects each legacy codec's backend independently. Hardware MPEG-2 remains available when H.263+ falls back to software, and legacy probing no longer requires a working H.264 encoder. Hosts advertise H.264 only after a successful probe.
Capture workers are shared within each encoder backend, with separate lifetimes for different backends and monitor-switch requests broadcast to every active group. Regression tests cover both session arrival orders, cleanup/restart, failed startup, legacy-only host advertisements, strict client negotiation, and real software encode/decode round trips for both legacy codecs.
Document the client-independent capability bits, SDP identifiers, and GameStream framing. Explicit capability initialization also fixes the ARM64 Clang
-Wmissing-field-initializersfailure in the reported job.The round-trip test computes its buffer size in
std::size_tbefore multiplication, addressing the CodeQL integer-promotion finding.The moonlight-common-c submodule is pinned to
ed6b2da, shared with Moonlight-XboxOG. Thenxdk-decoder-choicesbranch is rebased onto upstream94c65fd. The shared codec implementation is a single source-only commit.TODO:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
cmake --build cmake-build-release --target sunshine test_sunshine --parallel 4passed.-Werror=missing-field-initializers.uv run --locked lb-update-clang-formatandgit diff --checkpassed.Native validation covers the current native source, test, CMake, and submodule trees, which are unchanged by the final package-only master update. Web checks were rerun with the updated lockfile. The display-probing function was verified to match master's platform-specific behavior exactly after conflict resolution.
Native AMD/Quick Sync tests were skipped on this machine. Linux/macOS and ARM64 builds, full network transport, and Xbox hardware streaming were not run locally. The Web UI Markdown test used LF checkout line endings. Hosted CI results are separate from the local validation.
Type of Change
Checklist
AI Usage
See our AI usage policy.
AI tools generated much of the feature and assisted with implementation review, backend/capture changes, the shared protocol, rebasing, CI fixes, documentation, and tests.