Skip to content

Stop British to American from rewriting standard American words #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Sep 1, 2026
Merged

Stop British to American from rewriting standard American words #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions se5/BritishToAmerican/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ opposite direction. Reuses the bundled word list (~1850 pairs) and the shared
`EnglishVariantConverter` from [`Plugin-Shared`](../Plugin-Shared/) with
`Direction = BrToUs`.

Word list pairs marked `only="UsToBr"` are skipped in this direction: their
British-side word is also standard American English (car, film, flat, lift,
torch...), so "converting" it would rewrite text that is already correct
American (issue [#14374](https://github.com/SubtitleEdit/subtitleedit/issues/14374)).

## Build

See `.github/workflows/british-to-american.yml`.
9 changes: 9 additions & 0 deletions se5/Plugin-Shared/EnglishVariantConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ private void LoadBuiltInWordList()
continue;
}

// only="UsToBr" / only="BrToUs" restricts a pair to one direction. Used for
// vocabulary pairs whose "source" word is also standard in the target dialect
// (car, film, flat, lift...) - converting those would corrupt correct text.
var only = element.Attribute("only")?.Value;
if (only != null && !only.Equals(_direction.ToString(), StringComparison.OrdinalIgnoreCase))
{
continue;
}

var (from, to) = _direction == EnglishVariantDirection.UsToBr ? (us, br) : (br, us);

AddRule(from, to);
Expand Down
44 changes: 21 additions & 23 deletions se5/Plugin-Shared/WordList.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<Word us="analogs" br="analogues" />
<Word us="analyze" br="analyse" />
<Word us="analyzed" br="analysed" />
<Word us="analyzes" br="analyses" />
<Word us="analyzes" br="analyses" only="UsToBr" />
<Word us="analyzing" br="analysing" />
<Word us="anemia" br="anaemia" />
<Word us="anemic" br="anaemic" />
Expand Down Expand Up @@ -61,8 +61,8 @@
<Word us="armory" br="armoury" />
<Word us="artifact" br="artefact" />
<Word us="artifacts" br="artefacts" />
<Word us="automobile" br="car" />
<Word us="automobiles" br="cars" />
<Word us="automobile" br="car" only="UsToBr" />
<Word us="automobiles" br="cars" only="UsToBr" />
<Word us="ax" br="axe" />
<Word us="backpedaled" br="backpedalled" />
<Word us="backpedaling" br="backpedalling" />
Expand Down Expand Up @@ -246,8 +246,8 @@
<Word us="dishonored" br="dishonoured" />
<Word us="dishonoring" br="dishonouring" />
<Word us="dishonors" br="dishonours" />
<Word us="disk" br="disc" />
<Word us="disks" br="discs" />
<Word us="disk" br="disc" only="UsToBr" />
<Word us="disks" br="discs" only="UsToBr" />
<Word us="disorganization" br="disorganisation" />
<Word us="disorganizations" br="disorganisations" />
<Word us="disorganize" br="disorganise" />
Expand Down Expand Up @@ -401,7 +401,7 @@
<Word us="gamboling" br="gambolling" />
<Word us="garbage can" br="dustbin" />
<Word us="garbage cans" br="dustbins" />
<Word us="gasses" br="gases" />
<Word us="gasses" br="gases" only="UsToBr" />
<Word us="glamor" br="glamour" />
<Word us="gluing" br="glueing" />
<Word us="goiter" br="goitre" />
Expand Down Expand Up @@ -548,7 +548,6 @@
<Word us="louver" br="louvre" />
<Word us="louvered" br="louvred" />
<Word us="louvers" br="louvres" />
<Word us="luggage" br="baggage" />
<Word us="luster" br="lustre" />
<Word us="mailman" br="postman" />
<Word us="mailmen" br="postmen" />
Expand Down Expand Up @@ -621,12 +620,12 @@
<Word us="molting" br="moulting" />
<Word us="molts" br="moults" />
<Word us="mom" br="mum" />
<Word us="mommy" br="mummy" />
<Word us="mommy" br="mummy" only="UsToBr" />
<Word us="moms" br="mums" />
<Word us="monolog" br="monologue" />
<Word us="monologs" br="monologues" />
<Word us="movie" br="film" />
<Word us="movies" br="films" />
<Word us="movie" br="film" only="UsToBr" />
<Word us="movies" br="films" only="UsToBr" />
<Word us="multicolored" br="multicoloured" />
<Word us="mustache" br="moustache" />
<Word us="mustached" br="moustached" />
Expand Down Expand Up @@ -688,7 +687,7 @@
<Word us="paralleled" br="parallelled" />
<Word us="paralyze" br="paralyse" />
<Word us="paralyzed" br="paralysed" />
<Word us="paralyzes" br="paralyses" />
<Word us="paralyzes" br="paralyses" only="UsToBr" />
<Word us="paralyzing" br="paralysing" />
<Word us="parceled" br="parcelled" />
<Word us="parceling" br="parcelling" />
Expand Down Expand Up @@ -757,9 +756,8 @@
<Word us="prologs" br="prologues" />
<Word us="psychoanalyze" br="psychoanalyse" />
<Word us="psychoanalyzed" br="psychoanalysed" />
<Word us="psychoanalyzes" br="psychoanalyses" />
<Word us="psychoanalyzes" br="psychoanalyses" only="UsToBr" />
<Word us="psychoanalyzing" br="psychoanalysing" />
<Word us="pulled up" br="drew up" />
<Word us="pummeled" br="pummelled" />
<Word us="pummeling" br="pummelling" />
<Word us="quarreled" br="quarrelled" />
Expand Down Expand Up @@ -878,8 +876,8 @@
<Word us="smoldering" br="smouldering" />
<Word us="smolderingly" br="smoulderingly" />
<Word us="smolders" br="smoulders" />
<Word us="sneaker" br="trainer" />
<Word us="sneakers" br="trainers" />
<Word us="sneaker" br="trainer" only="UsToBr" />
<Word us="sneakers" br="trainers" only="UsToBr" />
<Word us="sniveled" br="snivelled" />
<Word us="sniveler" br="sniveller" />
<Word us="snivelers" br="snivellers" />
Expand Down Expand Up @@ -1231,14 +1229,14 @@
<!-- Additions: unambiguous vocabulary -->
<Word us="truck" br="lorry" />
<Word us="trucks" br="lorries" />
<Word us="elevator" br="lift" />
<Word us="elevators" br="lifts" />
<Word us="apartment" br="flat" />
<Word us="apartments" br="flats" />
<Word us="sidewalk" br="pavement" />
<Word us="sidewalks" br="pavements" />
<Word us="flashlight" br="torch" />
<Word us="flashlights" br="torches" />
<Word us="elevator" br="lift" only="UsToBr" />
<Word us="elevators" br="lifts" only="UsToBr" />
<Word us="apartment" br="flat" only="UsToBr" />
<Word us="apartments" br="flats" only="UsToBr" />
<Word us="sidewalk" br="pavement" only="UsToBr" />
<Word us="sidewalks" br="pavements" only="UsToBr" />
<Word us="flashlight" br="torch" only="UsToBr" />
<Word us="flashlights" br="torches" only="UsToBr" />
<Word us="gasoline" br="petrol" />
<Word us="eggplant" br="aubergine" />
<Word us="eggplants" br="aubergines" />
Expand Down
Loading