Tag every trace event with the program version (trace-client 0.4.0) - #28
Merged
Merged
Conversation
The vendored trace client is updated to 0.4.0, whose builder takes the program version and adds it as the `version` tag on every event. The version (spring.application.version, "unknown" when blank or left unfiltered as @project.version@) is passed to the builder, and the hand-added startup `version` tag is dropped. backup-completed now carries the version too; the README says so. The vendored client test is refreshed from upstream 0.4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored trace client is updated to trace-client 0.4.0, whose builder takes the program version and tags every event with it as
version.spring.application.version(@project.version@). When it is blank or left unfiltered,"unknown"is sent, so the builder can never throw at startup. Previously the tag was simply omitted in that case.versiontag onstartupis removed (the client now adds it);backup-completednow carries the version as well, and the README says so.TraceClientTestis refreshed from upstream 0.4.0;UsageReportingServiceTestis updated for the new bodies.Local test:
mvn clean verify(JDK 17) passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
drafted by Claude on behalf of Daniel Stephenson