Tag every trace event with the program version (trace-client 0.4.0) - #55
Merged
Merged
Conversation
The vendored trace client is updated to 0.4.0, whose builder takes the program version and adds it as the `version` tag on every event. The version (the JAR manifest Implementation-Version, "unknown" when not run from a built JAR) is passed to the builder, and the hand-added startup `version` tag is dropped. project-created now carries the version too; the README says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
Test Results124 tests ±0 124 ✅ ±0 1s ⏱️ ±0s Results for commit 798bd03. ± Comparison against base commit d8ea99d. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored trace client is updated to trace-client 0.4.0, whose builder takes the program version and tags every event with it as
version.Implementation-Version. When Parpt is not run from a built JAR,"unknown"is sent (previously the tag was omitted), so the builder can never throw at startup.versiontag onstartupis removed (the client now adds it);project-creatednow carries the version as well, and the README and first-run notice say so.UsageReporterTestis updated for the newproject-createdbody.Local test:
./gradlew test(JDK 21) passed, 124 tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
drafted by Claude on behalf of Daniel Stephenson