Tag every trace event with the program version (trace-client-python 0.3.0) - #207
Merged
Merged
Conversation
The vendored trace client is updated to 0.3.0, which takes the program version at construction and tags every event with it. FishE passes the version from version.txt (falling back to "unknown" so a missing file never stops startup), and the hand-added version tags on startup and save-loaded are dropped as redundant. What is sent is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
dmccoystephenson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored trace client (
src/trace_client.py, with its tests) is updated to trace-client-python 0.3.0, which requires the program version at construction and adds it as theversiontag on every event.version.txt(the same source the startup tag already used) via a newusageReporting.programVersion();"unknown"is passed if the file is missing or empty, so startup can never raise.versiontags onstartupandsave-loadedare dropped as redundant; the bodies sent are unchanged.TraceClient.disabled()and stays silent.Tests:
pytest(Python 3.12, SDL dummy drivers, as in CI) was run locally: 918 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
drafted by Claude on behalf of Daniel Stephenson