Point the stale web/game-worker.js references at tak's worker - #203
Merged
Merged
Conversation
The Worker moved into tak in #197 and web/game-worker.js was deleted, but four comments still named it. The Dockerfile's note also still said the server doesn't need tak and is pure stdlib - web/serve.py is now tak.web.serve, serving the kit's assets at /tak/. requirements.txt still said FishE was "being moved back onto" tak one module at a time; that move finished with #197. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (the diff was read in full after CI went green on the head commit):
Findings:
Summary: this is a comment-only drift fix following the tak move (#197). CI is green and no protected paths are touched ( This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The open-issue backlog was empty at triage, so a Stage A documentation accuracy sweep was run. In-repo comments were found that still describe the web runtime as it was before the move onto tak was finished in #197:
web/game-worker.jsis referenced, but it was deleted in Move onto tak (5/5): the web and Pyodide front-ends, and the web/ runtime #197. The Worker is now shipped by tak (tak/web/assets/game-worker.js) and is loaded through/tak/boot.jsinweb/index.html. The old path was still named in four comments:Dockerfile,src/config/config.py, and two intests/ui/test_pyodideUserInterface.py. Each is repointed at tak'sgame-worker.js. ThemakeSyncSaves()function, theexecof the entry point, and thejsonschemaloadPackagecall were each confirmed to exist in that file.web/serve.pyis nowfrom tak.web.serve import main, and the kit's assets are served from it at/tak/. The bullet is rewritten to say so. Importingtak.web.servewas checked and was found not to loadjsonschema, so the claim that jsonschema is only needed in the browser is kept.requirements.txtwas left saying FishE "is being moved back onto" tak "one module at a time". That move was finished with Move onto tak (5/5): the web and Pyodide front-ends, and the web/ runtime #197 (5/5). The line is changed to say FishE runs on tak, which is how the README already describes it.No behaviour is changed. Only comments are edited, so no tests were added.
No other drift was found by the sweep. These were checked:
FISHE_SAVE_DIR,damaged-<date>-<time>,/tak/assets, and the SDL handling in run.sh/test.sh.schemas/player.json,stats.jsonandtimeService.jsonagainst their*JsonReaderWriters. Every written field was found in its schema, and every schema field was found to be written.PLANNING.md.Test plan
SDL_VIDEODRIVER=dummy SDL_AUDIODRIVER=dummy: 910 passedweb/game-worker,web/clientandbeing moved: no matches remainNo tracking issue exists. The gap was found during triage, when the open-issue backlog was empty.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson