Repository navigation
Add SteamDeckHQ to Plugin Store - #1186
felixhirschfeld wants to merge 2 commits into
Conversation
Issues FoundNo issues with your PR description were found. Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
|
Testing reports for other plugins:
|
There was a problem hiding this comment.
- Update please used dependencies in the project
- All
reactrelated libs should be up to19.1.1, since that version is used by the Steam on Deck (at least, it was when I checked it few days ago) @decky/uiis indevDependencieswhich is incorrect. It should be independenciessince you import it and use into thesrcfolder- To be honest, I don't like the
install.shscript, which requiressudoon the entirepluginstree. There is no integrity check and at the end restartsDeckyservices. Would be nice just to have a.zipbuild which user will install through theDevelopertab as described inManual installation in Decky parsemethod fromsrc/pages/review.tsxdoesn't sanitize HTML content. This is like a rule of thumb to protect users from potential XSS attacks: https://en.wikipedia.org/wiki/HTML_sanitization
Please, take in the consideration that- To be honest, this is first time in my experience, when someone made an API call, and after their execution is getting errors like here:
Would be a better UX and DX to make separate calls for news and latestReviews with something like this:
useEffect(() => {
let disposed = false;
async function load<T>(
request: () => Promise<T>,
publish: (result: { data: T } | { error: string }) => void,
) {
try {
const data = await request();
if (!disposed) publish({ data });
} catch (error) {
if (!disposed) publish({ error: String(error) });
}
}
void load(getNews, setNewsState);
void load(getLatestReviews, setLatestReviewsState);
void load(async () => {
const appId = await getCurrentAppId();
if (appId === null) return { appId, review: null };
return { appId, review: await getReviewForApp(appId) };
}, setCurrentGameState);
return () => { disposed = true; };
}, []);Where each calls has it's on responsibility (S from SOLID rule). If something happens with News endpoint, user will still be able to see his Recommended settings / getReviewForApp
Sorry for my detailed comments. I'm treating it like a code review which I will do at my job for my colleagues.
The most important ones are 1, 2, 5 🤔 in my opinion
|
@ynhhoJ Thank you so much for looking into it! Detailed review is totally fine and looks valid at first glance. I will probably just fix everything this week and push it here. |
|
@ynhhoJ updated with your suggestions. i will change or remove the install script some other day. thanks again for taking the time to review and sorry for submitting the mess in the first place 😂 also uploaded screenshots |
Add SteamDeckHQ to Plugin Store
The plugin lets users browse SteamDeckHQ reviews and recommended settings.
Continues #769, the original SteamDeckHQ submission, which closed before merging. This submission adds the maintained fork.
I fixed the issues in the past submission and also made it functional again. I asked Noah from SDHQ back in March 2026 if he'd like me to finish the plugin and get it submitted. We also let users on SDHQ Discord install it and test it.
I just wanted to get the original version up and running. Future updates may follow.
The original author davocarli remains credited.
Task Checklist
Developer
Plugin
Backend
Community
Testing