Skip to content

Add SteamDeckHQ to Plugin Store - #1186

Open
felixhirschfeld wants to merge 2 commits into
SteamDeckHomebrew:mainfrom
felixhirschfeld:add/sdhq-plugin
Open

felixhirschfeld wants to merge 2 commits into
SteamDeckHomebrew:mainfrom
felixhirschfeld:add/sdhq-plugin

Conversation

@felixhirschfeld

@felixhirschfeld felixhirschfeld commented Nov 12, 2026 •

Copy link
Copy Markdown

Add SteamDeckHQ to Plugin Store

The plugin lets users browse SteamDeckHQ reviews and recommended settings.

Continues #769, the original SteamDeckHQ submission, which closed before merging. This submission adds the maintained fork.

I fixed the issues in the past submission and also made it functional again. I asked Noah from SDHQ back in March 2026 if he'd like me to finish the plugin and get it submitted. We also let users on SDHQ Discord install it and test it.

I just wanted to get the original version up and running. Future updates may follow.

The original author davocarli remains credited.

screenshot 85 screenshot 84

Task Checklist

Developer

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.
  • Generative AI was NOT used to write a majority of the code I am submitting.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Community

  • I have tested and left feedback on two other pull requests for new or updating plugins.
  • I have commented links to my testing report in this PR.

Testing

  • Tested by a third party on SteamOS Stable or Beta update channel.

@felixhirschfeld
felixhirschfeld requested a review from a team as a code owner November 12, 2026 08:23
@github-actions github-actions Bot added the plugin-addition Adding a plugin to the Plugin Store label Nov 12, 2026
@github-actions

Copy link
Copy Markdown

Issues Found

No issues with your PR description were found.

Next Steps

  1. If we found any issues above, please edit your pull request description to resolve them and leave a comment saying you've done so.
  2. For the quickest review, please see the Community section of the pull request template for how you can help other developers.
  3. Once your description is correct, a maintainer will review your pull request as soon as possible.

Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️

@felixhirschfeld

felixhirschfeld commented Nov 17, 2026 •

Copy link
Copy Markdown
Author

@github-project-automation github-project-automation Bot moved this to Ready for review in Plugin Review Nov 18, 2026

@ynhhoJ ynhhoJ left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Update please used dependencies in the project
  2. All react related libs should be up to 19.1.1, since that version is used by the Steam on Deck (at least, it was when I checked it few days ago)
  3. @decky/ui is in devDependencies which is incorrect. It should be in dependencies since you import it and use into the src folder
  4. To be honest, I don't like the install.sh script, which requires sudo on the entire plugins tree. There is no integrity check and at the end restarts Decky services. Would be nice just to have a .zip build which user will install through the Developer tab as described in Manual installation in Decky
  5. parse method from src/pages/review.tsx doesn't sanitize HTML content. This is like a rule of thumb to protect users from potential XSS attacks: https://en.wikipedia.org/wiki/HTML_sanitization
    Please, take in the consideration that
  6. To be honest, this is first time in my experience, when someone made an API call, and after their execution is getting errors like here:
image

Would be a better UX and DX to make separate calls for news and latestReviews with something like this:

useEffect(() => {
  let disposed = false;

  async function load<T>(
    request: () => Promise<T>,
    publish: (result: { data: T } | { error: string }) => void,
  ) {
    try {
      const data = await request();
      if (!disposed) publish({ data });
    } catch (error) {
      if (!disposed) publish({ error: String(error) });
    }
  }

  void load(getNews, setNewsState);
  void load(getLatestReviews, setLatestReviewsState);
  void load(async () => {
    const appId = await getCurrentAppId();
    if (appId === null) return { appId, review: null };
    return { appId, review: await getReviewForApp(appId) };
  }, setCurrentGameState);

  return () => { disposed = true; };
}, []);

Where each calls has it's on responsibility (S from SOLID rule). If something happens with News endpoint, user will still be able to see his Recommended settings / getReviewForApp


Sorry for my detailed comments. I'm treating it like a code review which I will do at my job for my colleagues.

The most important ones are 1, 2, 5 🤔 in my opinion

@github-project-automation github-project-automation Bot moved this from Ready for review to Changes requested in Plugin Review Nov 18, 2026
@felixhirschfeld

Copy link
Copy Markdown
Author

@ynhhoJ Thank you so much for looking into it! Detailed review is totally fine and looks valid at first glance.

I will probably just fix everything this week and push it here.

@AAGaming00
AAGaming00 requested a review from a team November 20, 2026 09:30
@AAGaming00 AAGaming00 moved this from Changes requested to Ready for review in Plugin Review Nov 20, 2026
@felixhirschfeld

Copy link
Copy Markdown
Author

@ynhhoJ updated with your suggestions. i will change or remove the install script some other day. thanks again for taking the time to review and sorry for submitting the mess in the first place  😂 also uploaded screenshots

@ynhhoJ ynhhoJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for testing!

@github-project-automation github-project-automation Bot moved this from Ready for review to Approved, needs testing in Plugin Review Nov 20, 2026

This branch was successfully deployed

1 active deployment
testing_env — 0c2df397 Deployed Nov 20, 2026 by felixhirschfeld via Build plugin (sdhq-plugin, true) #4257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin-addition Adding a plugin to the Plugin Store

Projects

Status: Approved, needs testing

Development

Successfully merging this pull request may close these issues.

2 participants