Skip to content

Update decky-dot-dns to v0.0.5 - #1180

Open
ohaiibuzzle wants to merge 2 commits into
SteamDeckHomebrew:mainfrom
ohaiibuzzle:fix/update-decky-dot-dns
Open

ohaiibuzzle wants to merge 2 commits into
SteamDeckHomebrew:mainfrom
ohaiibuzzle:fix/update-decky-dot-dns

Conversation

@ohaiibuzzle

@ohaiibuzzle ohaiibuzzle commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Update decky-dot-dns to v0.0.5

This release fixes a couple of outstanding issues since v0.0.2 was released on Store, mainly:

  • dns0.eu is dead. Replaced with dns4eu which is similar in functionality & privacy.
  • UI values doesn't survive update (this is due to QAM being remounted).
  • Ensure we doesn't accidentally ruin the user's DNS config if one of the field was accidentally left blank.

Other than these, it should behave identical to what it was before. No functionality was added since systemd-resolved hasn't changed since then.

Note for testers: Testing can be done by going to nextdns.io on a browser that does not perform secure DNS queries, use the tryout account (works fine) and flip between the DNS options available. You should see the detected DNS updated live in the Setup tab. See this video for what to expect.

Task Checklist

Developer

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.
  • Generative AI was NOT used to write a majority of the code I am submitting.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Community

Testing

  • Tested by a third party on SteamOS Stable or Beta update channel.

@ohaiibuzzle
ohaiibuzzle requested a review from a team as a code owner November 5, 2026 18:50
@github-actions github-actions Bot added the plugin-update Updating a plugin on the Plugin Store label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Issues Found

  • Both testing boxes are present in your description. Please remove one of them per the Markdown comment above the testing section.

Next Steps

  1. If we found any issues above, please edit your pull request description to resolve them and leave a comment saying you've done so.
  2. For the quickest review, please see the Community section of the pull request template for how you can help other developers.
  3. Once your description is correct, a maintainer will review your pull request as soon as possible.

Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️

@github-project-automation github-project-automation Bot moved this to Ready for review in Plugin Review Nov 5, 2026
AAGaming00
AAGaming00 previously approved these changes Nov 5, 2026

@AAGaming00 AAGaming00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately we can't get rid of the remounts, on frame the menu components works like that so if we disabled it on deck it would still happen on frame. there is a prop to disable it rn but that may need to be removed for frame
also you might want asyncio subprcoess instead of subprocess

@github-project-automation github-project-automation Bot moved this from Ready for review to Approved, needs testing in Plugin Review Nov 5, 2026
@felixhirschfeld

felixhirschfeld commented Nov 12, 2026 •

Copy link
Copy Markdown

Plugin Testing Report

Installed Plugins

Decky DoT DNS - 0.0.4-d6ba4c6
MagicPods - 2.0.24-1d03fd1
TabMaster - 3.0.1-1a124d2
HLTB for Deck - 2.0.12
SteamGridDB - 1.8.1
ProtonDB Badges - 1.3.4
Battery Tracker - 0.3.3
Steam Deck HQ - 1.0.0

Specifications

OS Version 3.9.5 (Beta)
Steam Version 1794424036 (Beta)
Decky 3.3.1

Issues

Has the following major blocking issue(s): None
Has the following minor non-blocking issue(s): None

Summary

The plugin works as expected. Screenshots attached.

screenshot 67 screenshot 68

@datbird

datbird commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Plugin Testing Report

Installed Plugins

  • Decky DoT DNS - 0.0.4-d6ba4c6
  • Deckamine - 1.0.2-9292e6b
  • Docky - 1.4.13-ba6663d
  • DeckySales - 1.2.5
  • Backlog Manager - 1.2.0
  • Mixer - 0.1.0
  • Blockslot - 0.1.4

Specifications

  • SteamOS 3.9.6_20261112.101 (Preview)
  • Steam 1794536281 (Beta)
  • Decky 3.3.0 (Stable)

Issues

Has the following major blocking issue(s): None
Has the following minor non-blocking issue(s):

  • After Restore Defaults the override file is removed and DNS goes back to my router, but the panel still shows the old custom values with Use DoT on, even after reopening it. drop_custom_dns_override in main.py doesn't reset the saved settings.

Summary

Installed from the testing store on a Steam Deck OLED. I picked each preset (CloudFlare, Google, DNS4EU, Quad9) and checked with resolvectl: each one wrote the config, opened a connection to the provider on port 853, and lookups came back over encrypted transport. A custom entry with the IPv6 fields left blank only wrote the IPv4 server, so the blank field fix works. The values survived a Decky restart, and Restore Defaults and uninstall both removed the override. The nextdns.io setup page in the Steam browser followed each switch. Screenshots of Cloudflare and Google attached.
pr1180-google
pr1180-cloudflare

@datbird datbird mentioned this pull request Nov 13, 2026
7 of 8 tasks
@maroun2

maroun2 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Plugin Testing Report

Installed Plugins

  • Decky DoT DNS - 0.0.4-d6ba4c6
  • Deck Progress Tracker - 1.5.1-1
  • DeckRoulette - 1.1.6-08b59a1
  • Decky Ludusavi - 1.2.2-1c704d6
  • Discord Status - 1.5.0-05e2060
  • Free Loader - 1.6.0-1cb17c9
  • Game Sync - 1.1.3-eb7000e
  • Game Theme Music - 1.7.1-1-4621abd
  • HLTB for Deck - 2.0.12-800f649
  • NonSteamLaunchers - 1.3.25
  • ProtonDB Badges - 1.3.4-809751c
  • SteamGridDB - 1.8.1-88b52c1

Specifications

  • Steam Deck OLED
  • SteamOS 3.9.5 (build 20261023.100) (Stable)
  • Steam 1794536281 (Stable)
  • Decky 3.3.1 (Pre-Release)

Issues

Has the following major blocking issue(s): None

Has the following minor non-blocking issue(s):

  • Updating or reinstalling the plugin turns the DNS override off without warning. On 3.3.1, Decky installs an update or reinstall by uninstalling the old copy first, and that runs _uninstall, which calls drop_custom_dns_override. I reinstalled the same version from the testing store with Quad9 active. The override file was removed and DNS went back to my router. The panel still showed the Quad9 values with Use DoT on, so it looks like DoT is active when it isn't. Decky uses the same uninstall step for store updates, so the next update of this plugin will probably do the same.
  • The blank-field guard misses one case: all fields blank with Use DoT on. Leaving only the IPv6 fields blank works: only the IPv4 server is written. But Apply with all four fields blank and Use DoT on writes DNS= + DNSOverTLS=yes. resolved then tries DoT against the router, and all lookups fail (All attempts to contact name servers or networks failed, curl https://github.com failed). Restore Defaults fixed it. Rejecting Apply when no IP is filled in would avoid this.
  • I can reproduce datbird's finding. Restore Defaults, and the "None" preset, remove the override and DNS goes back to the router. But settings.json keeps the old values, so after reopening the QAM the panel still shows them (e.g. Google, Use DoT on).
  • The preset dropdown always shows "Select a preset", even after choosing a preset and after reopening. selectedOption gets the whole option object from presetOptions.find(...), not its data value. I chose presets through the dropdown's onChange over CDP, not with the controller, so I haven't confirmed this with real controller input.
  • Uninstall leaves files behind. An empty /etc/systemd/resolved.conf.d/ stays, and ~/homebrew/settings/decky-dot-dns/settings.json too. Neither affects DNS.

Summary

I installed 0.0.4-d6ba4c6 from the testing store on a Steam Deck OLED, on Wi-Fi with IPv4 only. Before installing I saved the resolvectl status, resolved.conf and NetworkManager DNS settings.

Presets. I picked CloudFlare, Google, DNS4EU and Quad9 in turn. Each one wrote /etc/systemd/resolved.conf.d/decky-dot-dns.conf with the right servers, hostnames and DNSOverTLS=yes, and restarted systemd-resolved. Each one also:

  • showed up as the current global DNS server in resolvectl status
  • opened a TCP connection to the provider on port 853
  • answered resolvectl query with "acquired via ... encrypted transport: yes"

Live detection. I didn't use a browser. The test.nextdns.io endpoint showed a different resolver after each switch:

  • CloudFlare: 172.71.128.34
  • Google: 172.217.33.158
  • DNS4EU: 79.127.190.173
  • Quad9: 74.63.24.206

Custom DNS.

  • 1.1.1.1 + cloudflare-dns.com with blank IPv6 fields wrote only 1.1.1.1#cloudflare-dns.com, and DoT worked.
  • With Use DoT off, it wrote a plain DNS=1.1.1.1 / DNSOverTLS=no. The hostname fields were disabled and their contents were ignored.
  • 1.1.1.1 with a blank hostname and DoT on wrote DNS=1.1.1.1 with DoT, which still worked.

Settings persistence. The field values survived closing and reopening the QAM, a Decky frontend reload, and a plugin reinstall (backend restart). So the remount fix works for the UI. See the first issue for what happens to the actual DNS on reinstall.

Reset and uninstall. Restore Defaults, the "None" preset and uninstall all removed the override and restarted resolved. The plugin log in ~/homebrew/logs/decky-dot-dns/ shows each write, restart and removal, with no errors.

Code (submodule c94add6, tag v0.0.4). The plugin has the root flag. It writes the drop-in directly and runs systemctl restart systemd-resolved as root, without sudo or polkit. It doesn't touch resolved.conf or NetworkManager. The guard in push_custom_dns_override only skips pairs where the IP is blank. It doesn't stop a blank IP list, and it doesn't validate input.

Result. After uninstalling, resolvectl status, resolved.conf, NetworkManager DNS and the plugin list matched my saved state. The empty resolved.conf.d directory was the only leftover.

Not tested:

  • the NextDNS tryout account and Setup tab in a browser (I used the test.nextdns.io endpoint instead)
  • a NextDNS profile through the custom fields
  • IPv6 resolution (IPv6 is disabled on my network)
  • a real version update (I simulated it with a same-version reinstall)
  • a full plugin_loader service restart
  • controller or touch input (I drove the UI through CDP)
  • the Beta channel

Overall the plugin does what it says. The issues above are about how it handles edge cases and state, not blockers.

@ohaiibuzzle

Copy link
Copy Markdown
Contributor Author

@felixhirschfeld @datbird & @maroun2 thanks for the review. I think some items in there are actually enough on their own to require a fix.

In particular, the blank DNS edge case will be considered a blocking failure mode, because that's a complete loss of network access.

For the uninstallation issue, I'll fix it as well. I made an assumption that Decky would remove the configuration for the plugin as soon as it's uninstalled but apparently that's not the case.

@maroun2 maroun2 mentioned this pull request Nov 16, 2026
7 of 8 tasks
@ohaiibuzzle ohaiibuzzle changed the title Update decky-dot-dns to v0.0.4 Update decky-dot-dns to v0.0.5 Nov 19, 2026
@AAGaming00
AAGaming00 requested a review from a team November 19, 2026 15:26
@AAGaming00 AAGaming00 moved this from Approved, needs testing to Ready for review in Plugin Review Nov 19, 2026
@ohaiibuzzle

Copy link
Copy Markdown
Contributor Author

I've updated the plugin to release version v0.0.5 to address the reviewed issues.

Do note: DNS Settings are no longer dropped when the plugin is uninstalled. This is intentional, the reason being that it doesn't seem possible to distinguish between an uninstall-to-update and full uninstall, so I decided to keep the config in place and sync up the UI after an update to make sure settings are applied after an update.

@ynhhoJ

ynhhoJ commented Nov 20, 2026

Copy link
Copy Markdown
Member

@ohaiibuzzle , I correctly understand what on plugin uninstall / update are removed settings in the /etc/systemd/resolved.conf.d/decky-dot-dns.conf file, but plugin settings remain into ~/homebrew folder?

@ohaiibuzzle

ohaiibuzzle commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

@ohaiibuzzle , I correctly understand what on plugin uninstall / update are removed settings in the /etc/systemd/resolved.conf.d/decky-dot-dns.conf file, but plugin settings remain into ~/homebrew folder?

Basically, previously, on uninstall, the plugin will undo its systemd-resolved changes before removal. This restores system state, but the issue is that Decky doesn't have a way for you to tell if an uninstallation is from an update (Decky uninstalls first, then reinstall), or from a user-triggered uninstallation, they both call _uninstall(self).

I decided to optimize for the update case... but the caveat is now unless you explicitly tap "Restore Settings" in the menu, when you uninstall, your DNS config is kept as-is.

The only way to cleanly address this is to modify Decky to call it with something like _uninstall(self, forUpdate=false) so the plugin can handle it.

@ynhhoJ

ynhhoJ commented Nov 20, 2026

Copy link
Copy Markdown
Member

but the caveat is now unless you explicitly tap "Restore Settings" in the menu, when you uninstall, your DNS config is kept as-is.

@ohaiibuzzle , what if in that case your plugin will have an option what to do in case of plugin uninstall. Something like:

  • Return to default settings
  • Keep plugin settings
    (just for example)

In that case user will have more control other DNS settings

@ohaiibuzzle

Copy link
Copy Markdown
Contributor Author

@ynhhoJ It doesn't resolve the issue that we can't distinguish updates though, even if that option exists, if an user switch it to "remove settings on uninstall" then perform an update, it will again cause the issue where the GUI shows it's enabled when it isn't.

@github-project-automation github-project-automation Bot moved this from Ready for review to Approved, needs testing in Plugin Review Nov 21, 2026

This branch was successfully deployed

1 active deployment
testing_env — 6e2eefcf Deployed Nov 19, 2026 by ohaiibuzzle via Build plugin (decky-dot-dns, true) #4254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin-update Updating a plugin on the Plugin Store

Projects

Status: Approved, needs testing

Development

Successfully merging this pull request may close these issues.

6 participants