Repository navigation
Update decky-dot-dns to v0.0.5 - #1180
ohaiibuzzle wants to merge 2 commits into
Conversation
Issues Found
Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
AAGaming00
left a comment
There was a problem hiding this comment.
unfortunately we can't get rid of the remounts, on frame the menu components works like that so if we disabled it on deck it would still happen on frame. there is a prop to disable it rn but that may need to be removed for frame
also you might want asyncio subprcoess instead of subprocess
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None Has the following minor non-blocking issue(s):
SummaryI installed 0.0.4-d6ba4c6 from the testing store on a Steam Deck OLED, on Wi-Fi with IPv4 only. Before installing I saved the Presets. I picked CloudFlare, Google, DNS4EU and Quad9 in turn. Each one wrote
Live detection. I didn't use a browser. The
Custom DNS.
Settings persistence. The field values survived closing and reopening the QAM, a Decky frontend reload, and a plugin reinstall (backend restart). So the remount fix works for the UI. See the first issue for what happens to the actual DNS on reinstall. Reset and uninstall. Restore Defaults, the "None" preset and uninstall all removed the override and restarted resolved. The plugin log in Code (submodule Result. After uninstalling, Not tested:
Overall the plugin does what it says. The issues above are about how it handles edge cases and state, not blockers. |
|
@felixhirschfeld @datbird & @maroun2 thanks for the review. I think some items in there are actually enough on their own to require a fix. In particular, the blank DNS edge case will be considered a blocking failure mode, because that's a complete loss of network access. For the uninstallation issue, I'll fix it as well. I made an assumption that Decky would remove the configuration for the plugin as soon as it's uninstalled but apparently that's not the case. |
|
I've updated the plugin to release version v0.0.5 to address the reviewed issues. Do note: DNS Settings are no longer dropped when the plugin is uninstalled. This is intentional, the reason being that it doesn't seem possible to distinguish between an uninstall-to-update and full uninstall, so I decided to keep the config in place and sync up the UI after an update to make sure settings are applied after an update. |
|
@ohaiibuzzle , I correctly understand what on plugin uninstall / update are removed settings in the |
Basically, previously, on uninstall, the plugin will undo its systemd-resolved changes before removal. This restores system state, but the issue is that Decky doesn't have a way for you to tell if an uninstallation is from an update (Decky uninstalls first, then reinstall), or from a user-triggered uninstallation, they both call I decided to optimize for the update case... but the caveat is now unless you explicitly tap "Restore Settings" in the menu, when you uninstall, your DNS config is kept as-is. The only way to cleanly address this is to modify Decky to call it with something like |
@ohaiibuzzle , what if in that case your plugin will have an option what to do in case of plugin uninstall. Something like:
In that case user will have more control other DNS settings |
|
@ynhhoJ It doesn't resolve the issue that we can't distinguish updates though, even if that option exists, if an user switch it to "remove settings on uninstall" then perform an update, it will again cause the issue where the GUI shows it's enabled when it isn't. |




Update decky-dot-dns to v0.0.5
This release fixes a couple of outstanding issues since v0.0.2 was released on Store, mainly:
Other than these, it should behave identical to what it was before. No functionality was added since systemd-resolved hasn't changed since then.
Note for testers: Testing can be done by going to nextdns.io on a browser that does not perform secure DNS queries, use the tryout account (works fine) and flip between the DNS options available. You should see the detected DNS updated live in the Setup tab. See this video for what to expect.
Task Checklist
Developer
Plugin
Backend
Community
Testing