Repository navigation
Week 17 full test pass - #68
Merged
Merged
Conversation
…ejection error doesnt comes
…another fix which is profile pic wasnt showing perfectly on home screen
…nt showing up on the screen
…nt showing up on the screen
Resolve add/add conflict in analytics_screen.dart by keeping the week-14 data visualization version (dev had the week-5 placeholder). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Consolidate bloc folders to view_model/ (users, balance, group, transaction) to match the imports and week-18 layout - Remove legacy duplicates: lib/data/transactions/ and lib/ui/transaction/view_models/ bloc+event - Move drift generated files next to their sources (part 'x.g.dart') and drop lib/generated/ + build.yaml, matching week-18 - Add BalancesDao.getByPublicKeyAndCurrency and UserRepositoryImpl.getCurrentUser - Register the settlement route used by friends_Detail - Commit zplit-logo(1).png referenced in pubspec and declare zplit-logo.png used by the splash screen (asset bundle failed to build) - Add bloc_test and mocktail dev dependencies used by the tests - Update week-5 bloc/DAO tests to current paths and APIs; drop the default counter widget_test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bring back lib/data/transactions/transaction_repository.dart and lib/ui/transaction/view_models/{transaction_bloc,transaction_event,transaction_state}.dart unchanged from 75c6122.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bring back lib/ui/{users,balance,group}/view_models/*, build.yaml and test/widget_test.dart unchanged from 75c6122 so the PR does not delete them. lib/generated/ stays removed: its generated code now lives next to the DAOs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev's squash of StabilityNexus#60 is identical to fix/week-7-bluetooth, which this branch already contains, so conflicts resolve to this branch's side. Brings in the CI Flutter version change from StabilityNexus#54. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Errors inherited from dev: - Add view_model/ copies of the users, balance, group blocs and transaction_state (what every import uses); legacy view_models/ copies are kept unchanged - Move drift generated files next to their sources (part 'x.g.dart') - Add BalancesDao.getByPublicKeyAndCurrency and UserRepositoryImpl.getCurrentUser - Exclude the unused legacy lib/data/transactions/ and lib/ui/transaction/view_models/ from analysis instead of deleting them Tests: - Add bloc_test and mocktail dev dependencies - Update week-5 DAO/bloc tests to current paths and APIs - Rewrite stale widget tests for the current screens (bloc providers, current copy, paise amounts) and replace the default counter test with an onboarding smoke test Lints: - withOpacity -> withValues, Share.share -> SharePlus, activeColor -> activeThumbColor, print -> debugPrint - mounted checks after async gaps, braces, unused imports/fields - Declare equatable as a direct dependency - Disable file_names lint for existing PascalCase file names Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the analyzer/test fix from feature/nfc-tap-to-share. Conflicts: - pubspec.yaml: keep both flutter_p2p_connection and equatable - home_Screen.dart: keep week-11's scrollable empty state, with withValues instead of withOpacity Follow-ups for week-11 code so analyze stays clean: - withOpacity -> withValues in week-11 additions - wifi_direct_Service: print -> debugPrint, keep unused _teardownHost with an ignore - invite_friends: drop unnecessary '!' on wifiState - invite_friends_screen_test: provide a mock WifiBloc and cover the WiFi Direct section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the analyzer/test fix via feat/week-11 (no conflicts). Follow-ups for week-13 code so analyze stays clean: - Declare google_mlkit_text_recognition in pubspec (ocr_service imports it; same line week-14 adds) - ocr_service: print -> debugPrint, drop unnecessary '!' - receipt_scan_screen: withOpacity -> withValues Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the analyzer/test fix via week-13. Conflicts: - pubspec.yaml: keep fl_chart + equatable, and flutter_launcher_icons + bloc_test + mocktail Follow-ups for week-14 code so analyze/test stay clean: - withOpacity -> withValues in week-14 additions - analytics_screen: swapAnimationDuration -> duration (fl_chart) - Commit zplit-logo(1).png referenced in pubspec (and zplit_logo.png used by flutter_launcher_icons) and declare zplit-logo.png used by the splash screen, as on week-17 - Analytics_screen_test: rewrite the AnalyticsScreen group for the data-visualization screen (mock blocs, fixtures, charts, filters) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the analyzer/test fix via week-14. Conflicts: - pubspec.yaml: keep url_launcher and equatable Follow-ups for week-15-16 code: - withOpacity -> withValues in settlement additions - Register AppRoutes.settlement (used by friends_Detail) as on week-17 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the analyzer/test fix via week-15-16 (no conflicts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev's squash of StabilityNexus#61 is identical to feature/nfc-tap-to-share, which this branch already contains, so all conflicts resolve to this branch's side. No content change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#61 squash via feat/week-11 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#61 squash via week-13-ocr-receipt-scanning (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#61 squash via week-14-data-visualization (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#61 squash via week-15-16-settlement (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev's squash of StabilityNexus#63 is identical to feat/week-11, which this branch already contains; conflicts resolve to this branch's side. No content change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#63 squash via week-13 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#63 squash via week-14 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#63 squash via week-15-16 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev's squash of StabilityNexus#65 is identical to week-13-ocr-receipt-scanning, which this branch already contains; conflicts resolve to this branch's side. No content change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#65 squash via week-14 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#65 squash via week-15-16 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev's squash of StabilityNexus#66 is identical to week-14-data-visualization, which this branch already contains; conflicts resolve to this branch's side. No content change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up dev's StabilityNexus#66 squash via week-15-16 (no content change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Fixes #(TODO:issue number)
Screenshots/Recordings:
TODO: If applicable, add screenshots or recordings that demonstrate the interface before and after the changes.
Additional Notes:
AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
I have used the following AI models and tools: TODO
Checklist