Fix planned QST communicator mismatch diagnostics - #51
Merged
Conversation
The MPI QST parity regression requires a common communicator-mismatch marker. Planned analysis already rejected COMM_SELF operands collectively and kept outputs unchanged, but its shared plan/prototype validator used older wording. Use the common diagnostic marker while preserving ArgumentError and the congruent-communicator explanation. Exercise all three QST spatial inputs through both planned analysis entry points and retain output-preservation checks. Refresh the audited-tree digest and verification evidence. Validation: full test/parity/runtests_mpi.jl passed on 2 and 4 ranks, including all 55 QST compatibility checks per rank. Before the fix, the expanded QST block had 49 passes and 6 diagnostic failures per rank. All 4,945 final audit checks passed.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planned QST analysis rejected incompatible MPI communicators but used an older error message, causing the parity check for
communicator mismatchto fail. Align the shared plan/prototype diagnostic with the other collective preflight errors; rejection remains collective and outputs remain unchanged.Expand the regression to cover all three spatial input positions through
analysis_qst!anddist_analysis_qst!. Refresh the audit evidence for the changed source and tests.Validation (Julia 1.12.4):
test/parity/runtests_mpi.jlpassed with 2 and 4 ranks, including all 55 QST compatibility checks and 66 SHTns 3.7 fixture checks per rank.