Decimal persistence round trip through IPC and parquet - #3
Merged
Conversation
Add a `decimal` feature that carries DecimalArray columns (Decimal32, Decimal64, Decimal128) through the full IPC persistence path: schema encoding, record batch write, IPC read (both streaming and file protocols), windowed read, CSV rendering, and parquet type mapping. Each decimal width stores its unscaled integer values in the IPC body alongside its precision and scale in the schema's Decimal flatbuffer type (tag 7). The reader reconstructs the DecimalArray with the original precision, scale, storage values and null mask. Tests cover write, full read, windowed read, multi-batch write, stream round-trip, CSV scaled-value output, and parquet physical/ logical type mapping for all three widths with nulls.
pbower
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decimalfeature to lightstream forwarding tominarrow/decimalDecimal32,Decimal64andDecimal128columns with precision, scale and bitWidth in the schema and storage buffers in record batchesDecimalArrayfrom the schema's precision/scale and the storage buffer for both Arc-based and SharedBuffer pathsTest plan