fix(deps): pin click >=8.3.3,<8.4 for PYSEC-2026-2132 (CI #535) - #154
Draft
Sbussiso wants to merge 2 commits into
Draft
fix(deps): pin click >=8.3.3,<8.4 for PYSEC-2026-2132 (CI #535)#154Sbussiso wants to merge 2 commits into
Sbussiso wants to merge 2 commits into
Conversation
Bumps [websockets](https://github.com/python-websockets/websockets) from 16.1.1 to 17.0.1. - [Release notes](https://github.com/python-websockets/websockets/releases) - [Commits](python-websockets/websockets@16.1.1...17.0.1) --- updated-dependencies: - dependency-name: websockets dependency-version: 17.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
CI run #535 (30854790700) failed the backend pip-audit --strict gate: click 8.3.1 carries PYSEC-2026-2132 (high). click is a transitive dep via uvicorn (which only requires click>=7.0), so the unpinned solver was free to land the vulnerable 8.3.1. Add an explicit floor ~=8.3.3 (>=8.3.3,<8.4) to take the minimum patched release on the 8.3 line without forcing the 8.4.x minor bump, keeping the change patch-only. Regenerate uv.lock -> click 8.3.3. Verified locally: uv run pip-audit --strict -> No known vulnerabilities found uv run pytest -q -> 699 passed uv run ruff check -> All checks passed Note: this branch also has an UNRELATED frontend audit failure (react-router-dom 7.18.2 / GHSA-qwww-vcr4-c8h2, high) whose only fix is a 7.x->8.x major bump -- out of scope for a patch-only security pin; flagged separately via commit comment for human triage. This PR addresses only the backend (click) finding.
Sbussiso
referenced
this pull request
Aug 3, 2026
Bumps [redis](https://github.com/redis/redis-py) from 7.4.0 to 8.1.0. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@v7.4.0...v8.1.0) --- updated-dependencies: - dependency-name: redis dependency-version: 8.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
CI run #535 (30854790700) on
dependabot/uv/backend/redis-8.1.0failed two independent audit gates:pip-audit --strictclick 8.3.1→ PYSEC-2026-2132npm audit --audit-level=high --omit=devreact-router-dom 7.18.2→ GHSA-qwww-vcr4-c8h2 (RSC CSRF bypass)Neither is related to the redis 7.4.0→8.1.0 bump this Dependabot branch carries.
What this PR fixes (backend / click)
clickis a transitive dependency pulled in viauvicorn(which only requiresclick>=7.0). Without an explicit floor, the resolver landed the vulnerable8.3.1.click>=8.3.3,<8.4tobackend/pyproject.toml(minimum patched release on the 8.3 patch line;<8.4keeps it patch-only — no minor bump).uv.lock→click 8.3.3.Local verification (all green)
What this PR does NOT fix (frontend / react-router) — needs human decision
react-router-domis at^7.18.2(resolved 7.18.2), which is inside the advisory's vulnerable range>=7.12.0, <8.3.0. The only patched version is 8.3.0 — a 7.x → 8.x major version bump, which npm itself flags as a breaking change. npm's alternative suggestion (downgrade to7.11.0) is also a breaking change and re-enters the pre-vuln line at the cost of any 7.12+ features in use.A major router version migration is not a safe, mechanical fix and shouldn't ride on an unrelated Dependabot redis branch. It's flagged in a commit comment on
88e8e17for separate triage — likely its own branch + PR with the frontend test suite run to catch any 7→8 API breakage.Scope
dependabot/uv/backend/redis-8.1.0(base of this PR).