fix(backend): pin click>=8.3.3 for PYSEC-2026-2132 (CI run #522) - #142
Draft
Sbussiso wants to merge 2 commits into
Draft
fix(backend): pin click>=8.3.3 for PYSEC-2026-2132 (CI run #522)#142Sbussiso wants to merge 2 commits into
Sbussiso wants to merge 2 commits into
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.4...v10.8.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
CI run #522 (30308109150) on dependabot/npm_and_yarn/frontend/eslint-10.8.0 failed the backend `pip-audit --strict` step: click 8.3.1 PYSEC-2026-2132 fix: 8.3.3 click is a transitive dep of uvicorn (0.51.0 pulls click 8.3.1). Add a [tool.uv] constraint-dependencies pin — the established pattern in this repo for transitive security bumps (see authlib/urllib3/idna/starlette/ pip/cryptography/joserfc/msgpack/pydantic-settings above). uv resolves to 8.4.2 (latest compatible 8.x), a patch/minor bump that's API-safe for uvicorn's decorator/argument usage. Verified locally: - uv sync --extra dev : clean - uv run pip-audit --strict : No known vulnerabilities found - uv run pytest -q : 699 passed This unblocks the backend job of run #522. The frontend job's react-router CVE (GHSA-qwww-vcr4-c8h2) has no safe automated fix on this branch — see the PR description for the reachability analysis and options; left for a human decision. Remove this constraint once uvicorn's own pin moves past 8.3.3.
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/frontend/eslint-10.8.0
branch
3 times, most recently
from
August 3, 2026 21:33
8633fdf to
19594ab
Compare
Sbussiso
referenced
this pull request
Aug 3, 2026
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.4...v10.8.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Sbussiso
referenced
this pull request
Aug 3, 2026
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.4...v10.8.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI triage — run #522 (30308109150)
Branch `dependabot/npm_and_yarn/frontend/eslint-10.8.0` (commit `6a1d826`) failed two independent dependency-scan jobs. This PR fixes the one that has a safe automated fix and documents the other for a human decision.
✅ Backend — `pip-audit --strict` → FIXED in this PR
`click` is a transitive dep of `uvicorn` (0.51.0 pulls click 8.3.1). Added a `[tool.uv] constraint-dependencies` pin `click>=8.3.3` — the established pattern in this repo for transitive security bumps (same shape as the authlib / urllib3 / idna / starlette / pip / cryptography / joserfc / msgpack / pydantic-settings pins already in `pyproject.toml`). `uv lock` resolves to 8.4.2 (latest compatible 8.x), a patch/minor bump that is API-safe for uvicorn's decorator/argument usage.
Verified locally:
Remove the constraint once uvicorn's own pin moves past 8.3.3.
Why no automated fix here:
npm's only suggested remediation is a breaking downgrade. `npm audit fix --force` wants to install `react-router-dom@7.11.0`, a major-range downgrade from the current `7.18.1`. That is a breaking change, not a safe bump.
An `overrides`-based bump to `react-router@8.3.0` (the fixed version) is risky at runtime. `react-router-dom@7.18.1` declares `"react-router": "7.18.1"` — an exact pin, not a range. Forcing `react-router` to 8.x via `overrides` (the repo's existing pattern for `postcss` / `js-cookie`) would let `npm audit` go green but creates an API mismatch: `react-router-dom@7.18.1` expects the `react-router@7.18.1` surface, and 8.x is a major version with breaking exports. It may compile and may even pass the build, but could fail at runtime in routing/rendering. That is not a "clear, safe fix," so I did not apply it autonomously.
The vulnerable path is very likely not reachable in this app. The advisory is specifically about RSC mode CSRF bypass allowing action execution before a 400 response. This frontend uses declarative ``/`` with `BrowserRouter` (`src/main.jsx`, `src/App.jsx`) — no data router (`createBrowserRouter`/`RouterProvider`), no loaders/actions, no `useFetcher`/`useSubmit`/`
`. The CSRF-bypass-in-action-execution path requires the data/router-action machinery, which this app does not use.Options for a human (in order of recommendation):
I've left the frontend job red on this branch intentionally — applying option 1 or 3 belongs to a deliberate human decision, not an autonomous CI-fix.
What this PR does
Draft until reviewed — the frontend CVE decision is called out above.