Repository navigation
Conversation
…hor reads as a non-member A token outside the org reads a public member's verdict as MEMBER and a private member's as CONTRIBUTOR. privateMarkerAuthors returned true only when every well-formed verdict read as a non-member, so one public member's verdict among the private ones made the rest score as not reviewed. It now returns true when any verdict naming one of the PR's own commits is by a non-member. pull_requests.fixed_after_review, which read the same verdicts without the check, gets it too. Closes SoulCraft-Org#169 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: paulfoley <268432743+paulfoley@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
privateMarkerAuthorsreturns true when any well-formedReview: MERGE|BLOCK at <sha>verdict (one naming a commit of its own PR) is by a non-member, not only when all are.pull_requests.fixed_after_reviewgets the same checkpull_requests.reviewedalready had. The could_not_check text now says a verdict cannot be told from an outsider'snode --test quality/collectors/github/github-more.test.mjs quality/collectors/github/github.test.mjs(79 pass). In "counts a member's Review: MERGE|BLOCK at comment as a review", the mix of two private-member verdicts and one public-member verdict (formerly asserted 33.3) now reads could_not_check on both metrics. With the old rule it failsfound.length > 0 && !found.some(...)🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.